Respect climate system_mode access bit #14715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
xworld21
added a commit
to xworld21/zigbee2mqtt
that referenced
this pull request
Nov 6, 2022
…oenkk#14715)" This reverts commit 58c8001.
Koenkk
pushed a commit
that referenced
this pull request
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address the small issue brought up in Koenkk/zigbee-herdsman-converters#4832 (comment): in the Home Assistant extension, the
mode_command_topicshould appear only ifsystem_modehas theACCESS_SETbit set. Otherwise, Home Assistant will try to usesetand cause unnecessary error messages.