Allow to specify full file name in value reference '!' #14955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This `network_key: '!secret network_key'` is really confusing because it looks like a YAML tag named 'secret' and a value "network_key". When we write `network_key: '!secret.yaml network_key'` instead, it's a little clearer what's going on. Also, it's more consistent with file references in 'devices' and 'groups'.
Koenkk
reviewed
Nov 13, 2022
| @@ -199,7 +199,7 @@ describe('Settings', () => { | |||
| mqtt: { | |||
| server: '!secret server', | |||
| user: '!secret username', | |||
| password: '!secret password', | |||
| password: '!secret.yaml password', | |||
There was a problem hiding this comment.
Can you leave the old test to ensure this change is backwards compatible?
There was a problem hiding this comment.
There are multiple instances of !secret in this test, all asserted, I changed just one of them to test another variant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
network_key: '!secret network_key'is really confusing because it looks like a YAML tag named 'secret' and a value "network_key".When we write
network_key: '!secret.yaml network_key'instead, it's a little clearer what's going on. Also, it's more consistent with file references in 'devices' and 'groups'.