Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openhab 2.4 compatibility #1588 #1589

Merged
merged 1 commit into from
Jun 15, 2019
Merged

Openhab 2.4 compatibility #1588 #1589

merged 1 commit into from
Jun 15, 2019

Conversation

yozik04
Copy link
Contributor

@yozik04 yozik04 commented May 31, 2019

Resolves #1588

@yozik04
Copy link
Contributor Author

yozik04 commented May 31, 2019

Tests require fixing

@Koenkk
Copy link
Owner

Koenkk commented Jun 3, 2019

How does this affect existing setups?

@yozik04
Copy link
Contributor Author

yozik04 commented Jun 3, 2019

Maybe re adding automatically discovered items... I am putting [WIP] tag. As I did not got it fully working yet.

@yozik04 yozik04 changed the title Openhab 2.4 compatibility #1588 [WIP] Openhab 2.4 compatibility #1588 Jun 3, 2019
@yozik04
Copy link
Contributor Author

yozik04 commented Jun 3, 2019

I will make it fully working with current OpenHAB implementation, and see what damage it makes to existing setups. First commit in this pull request does not break anything...

@yozik04 yozik04 changed the title [WIP] Openhab 2.4 compatibility #1588 Openhab 2.4 compatibility #1588 Jun 14, 2019
@yozik04
Copy link
Contributor Author

yozik04 commented Jun 14, 2019

I think this is all changes that are required for compatibility with openhab 2.4. I have tested on HASS and all devices continued to work without any issues.

There is more work pending on Openhab side.

@Koenkk Koenkk changed the base branch from master to dev June 15, 2019 14:50
@Koenkk
Copy link
Owner

Koenkk commented Jun 15, 2019

I've confirmed that it has no regression with HASS.

Once the integration with openhab is fully completed, please also update:

Thanks!

@Koenkk Koenkk merged commit e9b5a58 into Koenkk:dev Jun 15, 2019
@yozik04
Copy link
Contributor Author

yozik04 commented Jun 15, 2019

Sure. Thank you.

@matfiz
Copy link

matfiz commented Jul 14, 2019

@yozik04 do you have any suggestions on how to efficiently use zigbee2mqtt with OpenHab 2.4? Is autodiscovery possible?

@yozik04
Copy link
Contributor Author

yozik04 commented Jul 14, 2019

From zigbee2mqtt side: Auto discovery already works in dev branch.
From Openhab side: Improvements are in https://github.com/openhab/openhab2-addons/pull/4927 pull request, maybe this will get to Openhab 2.5.

@matfiz
Copy link

matfiz commented Jul 14, 2019

Awesome, thx for the news @yozik04!

wilmardo pushed a commit to wilmardo/zigbee2mqtt that referenced this pull request Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants