Support ppb and ppm for VOC reporting in Home Assistant #22895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koenkk
reviewed
Jun 2, 2024
lib/extension/homeassistant.ts
Outdated
| @@ -908,10 +908,15 @@ export default class HomeAssistant extends Extension { | |||
| delete discoveryEntry.discovery_payload.device_class; | |||
| } | |||
|
|
|||
| // Home Assistant only supports µg/m³, not other units like ppb. | |||
| // Home Assistant uses a different voc device_class for µg/m³ versus ppb or ppm. | |||
| // https://github.com/Koenkk/zigbee2mqtt/issues/16057 | |||
| if (firstExpose.name === 'voc' && discoveryEntry.discovery_payload.unit_of_measurement !== 'µg/m³') { | |||
There was a problem hiding this comment.
Let's do this around
zigbee2mqtt/lib/extension/homeassistant.ts
Line 899 in 0e6da85
if here.
|
Thank you! Does this look closer to what you are expecting? |
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See home-assistant/core#92973.