Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable timestamp #2357

Merged
merged 5 commits into from Nov 17, 2019
Merged

Customizable timestamp #2357

merged 5 commits into from Nov 17, 2019

Conversation

Kryzek
Copy link
Contributor

@Kryzek Kryzek commented Nov 17, 2019

Added setting timestamp_format under advanced in continuation of commit 44db557

If not set, it will default to YYYY-MM-DD HH:mm:ss formatting.

With different settings:
timestamp_format: 'MMMM Do YYYY, h:mm:ss a'
We will get:
November 17th 2019, 6:50:57 pm: Starting zigbee2mqtt version 1.7.1+dev (commit #d2c4133)

timestamp_format: 'YYYY-MM-DD HH-mm-ss'```
2019-11-17 18-53-49: Starting zigbee2mqtt version 1.7.1+dev (commit #d2c4133)
timestamp_format: 'YYYY-MM-DD [<]HH-mm-ss[>]'
2019-11-17 <18-56-31>: Starting zigbee2mqtt version 1.7.1+dev (commit #d2c4133)

Damn it was hard to make PR with two files... 馃

Koenkk added a commit to Koenkk/zigbee2mqtt.io that referenced this pull request Nov 17, 2019
@Koenkk
Copy link
Owner

Koenkk commented Nov 17, 2019

Thanks for the PR! 馃悵 and congrats with the first contribution to this repo 馃槃

@Koenkk Koenkk merged commit 878a886 into Koenkk:dev Nov 17, 2019
@Kryzek
Copy link
Contributor Author

Kryzek commented Nov 18, 2019

Thanks!

My Git-FU is not very good yet, but I did manage.

I just wasn't able to get PR to get done from VS Code and I had to copy-paste to other environment to get PR done - and while at it I managed to mix up lines (thus revert) 馃榿 but luckily I noticed it. It's so much easier to do onefile-PRs.

Need some to do some practice...

Koenkk added a commit to Koenkk/zigbee2mqtt.io that referenced this pull request Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants