Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow no timestamp in log directory #356

Merged
merged 2 commits into from
Sep 17, 2018
Merged

Allow no timestamp in log directory #356

merged 2 commits into from
Sep 17, 2018

Conversation

azuwis
Copy link
Contributor

@azuwis azuwis commented Sep 11, 2018

I'd like to use logrotate to manage(rotate, compress) the log, add option to allow no timestamp in log directory.

Copy link

@ryanbeaton ryanbeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Becaus of #182 you may need to invert your approach, as in an advanced option for no tinestamping

@azuwis
Copy link
Contributor Author

azuwis commented Sep 12, 2018

Do you mean I should use an advanced option like:

advanced:
  log_directory_no_timestamp: true

this?

@ryanbeaton
Copy link

Yes :)
No timestamp is how it used to be and #182 changed it to timestamp.

Sent with GitHawk

@azuwis
Copy link
Contributor Author

azuwis commented Sep 12, 2018

Yes :)
No timestamp is how it used to be and #182 changed it to timestamp.

Sent with GitHawk

Done.

@Koenkk
Copy link
Owner

Koenkk commented Sep 17, 2018

Updated the option to log_directory_timestamp (which is true) by default.

Thanks!

@Koenkk Koenkk merged commit 60e72c6 into Koenkk:dev Sep 17, 2018
Koenkk added a commit that referenced this pull request Sep 18, 2018
@Koenkk
Copy link
Owner

Koenkk commented Sep 18, 2018

in 2fd59cb I've removed this option and merged it with the log_directory option.

%TIMESTAMP% is now used as a placeholder for the timestamp in log_directory.

e.g.

  • /var/log/%TIMESTAMP% will produce directories with timestamp
  • /var/log without (which replaced this option).

wilmardo pushed a commit to wilmardo/zigbee2mqtt that referenced this pull request Sep 26, 2019
* Allow no timestamp in log directory

* Update log_directory_timestamp option
wilmardo pushed a commit to wilmardo/zigbee2mqtt that referenced this pull request Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants