Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not fallback to string if array can be parsed #5420

Merged
merged 4 commits into from
Dec 27, 2020
Merged

Do not fallback to string if array can be parsed #5420

merged 4 commits into from
Dec 27, 2020

Conversation

foxylion
Copy link
Contributor

This in needed, otherwise ZIGBEE2MQTT_CONFIG_ADVANCED_NETWORK_KEY can never be set to a JSON object (array).

@foxylion
Do not fallback to string if array can be parsed
91fa27d 
This in needed, otherwise ZIGBEE2MQTT_CONFIG_ADVANCED_NETWORK_KEY can never be set to a JSON object (array).
@branch-switcher branch-switcher bot changed the base branch from master to dev December 27, 2020 16:54
@branch-switcher
Copy link

Hello @foxylion. The base branch of this pull request has been updated to the dev branch. Please revisit the changes and make sure that there are no conflicts with the new base branch. Thank you for your contributions.

@Koenkk Koenkk changed the base branch from dev to master December 27, 2020 18:29
@branch-switcher branch-switcher bot changed the base branch from master to dev December 27, 2020 18:29
@branch-switcher
Copy link

Hello @foxylion. The base branch of this pull request has been updated to the dev branch. Please revisit the changes and make sure that there are no conflicts with the new base branch. Thank you for your contributions.

@Koenkk
Copy link
Owner

Koenkk commented Dec 27, 2020

Thanks!

@Koenkk Koenkk merged commit 0b8cd23 into Koenkk:dev Dec 27, 2020
@foxylion foxylion deleted the patch-1 branch December 27, 2020 18:52
@foxylion
Copy link
Contributor Author

Perfect, thanks @Koenkk. Confirmed that this is now working.

One thing I noticed. The environment variable contents are stored inside the configuration when it is saved due to changes on the device configuration. Is this expected?
I moved the variables to the secret file, then the configuration file is not modified.

@Koenkk
Copy link
Owner

Koenkk commented Dec 28, 2020

No that's indeed not expected. Can you update the write function to not save back values set through environment variables?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@foxylion @Koenkk