Support binding of server clusters towards clients #7127
Conversation
|
I have some old Schneider Electric Wiser equipment I am currently integrating and testing, one of the pre-reqs is the ability to bind the temperature sensors to the heating actuators, and the current implementation is more focused on lighting style, client to server binds. |
pklokke
force-pushed
the
support-report-binds
branch
from
45aabac
to
e634201
Compare
This allows binding of devices such as sleepy temperature sensors to heating actuators
pklokke
force-pushed
the
support-report-binds
branch
from
e634201
to
3e9e084
Compare
|
|
||
| if (source.endpoint.supportsOutputCluster(cluster) && targetValid) { | ||
| if (!anyClusterValid) { |
There was a problem hiding this comment.
If I understand correctly, binding the server clusters will only work when there are not client clusters to bind? What if you want to bind the server cluster and the device also has client clusters to bind?
There was a problem hiding this comment.
Some of the "anyClusterValid" target device types don't have real clusters to check, so that check would fail, and is redundant because any cluster is valid on the target.
The check inside the anyClusterValid covers both C->S, and S->C.
There was a problem hiding this comment.
Perhaps to be more clear, the matchingCluster checks ensure you aren't trying to bind a server to a server, or a client to a client. It doesn't care about direction, but just that there is a complimentary pair of the cluster of interest.
There was a problem hiding this comment.
Ah I see, misread this part, thanks!
There was a problem hiding this comment.
No worries! Happy to get my first commit in :-)
This allows binding of devices such as sleepy temperature sensors to heating actuators