Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with keyboard visibility checking #3

Merged
merged 1 commit into from
Jan 20, 2018
Merged

Fix bug with keyboard visibility checking #3

merged 1 commit into from
Jan 20, 2018

Conversation

anton-filimonov
Copy link

Steps to reproduce:

  • keyboardDismissMode = .interactive
  • Landscape mode
  • show keyboard
  • hide keyboard
  • portrait mode
  • scroll content

Result: got message like keyboard is visible
Expected result: no messages till keyboard appear

Steps to reproduce:
- keyboardDismissMode = .interactive
- Landscape mode
- show keyboard
- hide keyboard
- portrait mode
- scroll content

Result: got message like keyboard is visible
Expected result: no messages till keyboard appear
@Kofktu
Copy link
Owner

Kofktu commented Jan 20, 2018

@anton-filimonov
this PR has been shipped with 1.5.1 release and will be available in CocoaPods soon 🎉

@Kofktu Kofktu merged commit bb0332f into Kofktu:master Jan 20, 2018
@anton-filimonov
Copy link
Author

Great news. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants