Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shadow and corner radius to match iPadOS PIP #15

Merged
merged 5 commits into from
Apr 28, 2020
Merged

Add shadow and corner radius to match iPadOS PIP #15

merged 5 commits into from
Apr 28, 2020

Conversation

jordanhbuiltbyhq
Copy link
Contributor

No description provided.

@jordanhbuiltbyhq jordanhbuiltbyhq changed the base branch from master to develop April 24, 2020 16:41
@Kofktu
Copy link
Owner

Kofktu commented Apr 26, 2020

Why don't we add shadow properties to the PIPUsable Protocol and make it applicable?

ex)

struct Shadow {
    let offset: CGSize
    let opacity: CGFloat
    let radius: CGFloat
    let cornerRadius: CGFloat
    let conerCurve: 
}

protocol PIPUsable {
    var shadow: Shadow?
}

extension PIPUsable {
    var shadow: Shadow? { nil }
}

@jordanhbuiltbyhq
Copy link
Contributor Author

jordanhbuiltbyhq commented Apr 26, 2020

@Kofktu Done! A check is failing though due to using the iOS 12 SDK and CALayerCornerCurve is only available for iOS 13. Can that be bumped up?

@Kofktu
Copy link
Owner

Kofktu commented Apr 27, 2020

@jordanhbuiltbyhq
You can change the travis.yml file.

osx_image: xcode10 -> xcode11
SDK:"iphone12.0" -> "iphone13.0"

osx_image: xcode11

env:
- SDK="iphoneos13.0"

@jordanhbuiltbyhq
Copy link
Contributor Author

@Kofktu an error is occurring with that change 🤔

xcodebuild: error: Failed to build workspace Example with scheme Example.
631	Reason: A build only device cannot be used to run this target.
632	Recovery suggestion: No supported iOS devices are available. Connect a device to run your application or choose a simulated device as the destination.
633The command "xcodebuild clean build test -workspace Example/Example.xcworkspace -scheme Example -sdk $SDK -configuration Debug -enableCodeCoverage YES CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO | xcpretty -c" exited with 70.

@Kofktu
Copy link
Owner

Kofktu commented Apr 28, 2020

@jordanhbuiltbyhq
I'll fix it later.
Thank you very much.

@Kofktu Kofktu merged commit 3a73774 into Kofktu:develop Apr 28, 2020
@jordanhbuiltbyhq jordanhbuiltbyhq deleted the shadow-corners branch April 28, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants