Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetMHCIIpan 3.1 class is missing crucial methods #37

Closed
jonasscheid opened this issue Jul 17, 2021 · 1 comment
Closed

NetMHCIIpan 3.1 class is missing crucial methods #37

jonasscheid opened this issue Jul 17, 2021 · 1 comment

Comments

@jonasscheid
Copy link
Collaborator

NetMHCIIpan 3.1 class in EpitopePrediction/External.py is missing crucial methods like parse_external_result. It cannot be used. Since NetMHCIIpan 3.0 is covered by Epytope I would propose to remove this class and optionally add the newer Version NetMHCIIpan 4.0 to Epytope.
@christopher-mohr
Copy link
Collaborator

Hi @jonasscheid, I think it should be fine since the class inherits from NetMHCIIpan 3.0. I guess the output formats of these methods are identical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@christopher-mohr @jonasscheid