-
Notifications
You must be signed in to change notification settings - Fork 37
Provide a basic variable hierarchy feature #156
Conversation
9130ba7
to
825da6b
Compare
@vinny-sabatini what are your thoughts on this, esp. with regards to #147? Do I understand correctly that this could replace part of #147 as a somewhat more general approach? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea seems very cool! The implementation approach seems fine to me too; just numerous minor suggestions... :]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vinny-sabatini what are your thoughts on this, esp. with regards to #147? Do I understand correctly that this could replace part of #147 as a somewhat more general approach?
Yes that's the intention. The openshift-provision is something specific we use at Kohl's, but a lot of user might not want to go down that path.
d387b2a
to
442af14
Compare
d6d1142
to
23f74ad
Compare
7c1b36e
to
f38d4c4
Compare
This adds a feature to have a variable hierarchy within the same parameterSource repo. Simply providing a hierarchy.lst file will enable this feature. It's based on the already existing yq merge and simply adds processing of multiple directories. Additional Changes * Updates yq to 2.4.1 * Move configuration files for e2e test into folder test/e2e/configs * Correct ocp e2e test to allow EUNOMIA_REF and EUNOMIA_URI to work * Clean up helm test case and use the hello-world example as the base * Add cluster-admin role to helm example, to support creation of namespace
abb0417
to
2e3d260
Compare
Looks good. I cleaned up the commit history a bit. |
Description
This adds a feature to have a variable hierarchy within the same parameterSource repo. Simply providing a
hiera.lst
file will enable this feature. It's based on the already existingyq merge
and simply adds processing of multiple directories.Additional Changes
test/e2e/configs
EUNOMIA_REF
andEUNOMIA_URI
to workFixes #5
Type of change