Skip to content
This repository has been archived by the owner on Mar 11, 2022. It is now read-only.

Fix the automated e2e testing #69

Merged
merged 2 commits into from
Jul 17, 2019
Merged

Fix the automated e2e testing #69

merged 2 commits into from
Jul 17, 2019

Conversation

vinny-sabatini
Copy link
Member

@vinny-sabatini vinny-sabatini commented Jul 16, 2019

Description

Fixed E2E tests
Added Helm template test
Removed duplicate files for testing
Added KohlsTechnology quay images URL locations

Fixes #19

#9 created by @cnuland was the starting point for this PR.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Environment

  • Runtime version(Java, Go, Python, etc):

@vinny-sabatini
Copy link
Member Author

At this point I can run ./scripts/e2e-test.sh and the test pass.

The tests running are TestSimple and TestHelmTemplate, it looks like we have a file for ocp testing, but it's disabled.

If you want to test this locally before merging, you will have to change master to issue-19 in test/e2e/helm_template_test.go.

@Smiley73
Copy link
Contributor

Do we really want the branch hard coded?

@vinny-sabatini
Copy link
Member Author

vinny-sabatini commented Jul 16, 2019

@Smiley73 I've allowed the tests to take in the URI and Git Ref. as an environment variable (defaulting to our master branch if it's not set).
Let me know if you think this is sufficient.

Copy link
Contributor

@sanbornick sanbornick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sanbornick sanbornick merged commit 2b7a5b2 into master Jul 17, 2019
@sanbornick sanbornick deleted the issue-19 branch July 17, 2019 06:21
@sanbornick sanbornick mentioned this pull request Jul 17, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Make e2e Tests Work
3 participants