top down, left right reading ordered segments #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deimos1078 Thank you. we will check the pull request and if it does not break anything we will merge it. |
|
Hey @deimos1078, This looks good to me! Thank you for your contribution! I'm sorry it took so long - I have been on holiday in the past weeks. Have a nice day! |
OBrink
approved these changes
Aug 22, 2023
OBrink
added a commit
that referenced
this pull request
Aug 29, 2023
Kohulan
added a commit
that referenced
this pull request
Aug 29, 2023
…detected fix crash-inducing bug introduced with #72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An iteration of @Iagea 's pull request.
With this modification, the segments are sorted in order a person would read them on a paper. Since the bounding boxes can have quite variant heights, its necessary to use a pixel threshold within which two bounding boxes are accepted as "on the same line" for sorting purposes. This is pretty scrappy, but works for the purposes of my drughunter extractor project.