Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predictor_EfficientNet2.py is outdated #66

Closed
1 task done
OBrink opened this issue Jul 28, 2023 · 0 comments · Fixed by #67
Closed
1 task done

Predictor_EfficientNet2.py is outdated #66

OBrink opened this issue Jul 28, 2023 · 0 comments · Fixed by #67

Comments

@OBrink
Copy link
Collaborator

OBrink commented Jul 28, 2023

Issue Type

Feature Request

Source

GitHub (source)

DECIMER Image Transformer Version

2.3.1

OS Platform and Distribution

not relevant

Python version

not relevant

Current Behaviour?

Predictor_EfficientNet2.py has not been updated for a year.

Why is this relevant?
The script is not used in the Python package, but it contains an example of how to load the model from a checkpoint. If we publish the checkpoints, we should also provide an example of how to use them. In its current state, the code does not work (see confusion in #65).

Two options:

  • Delete it - It is not relevant for the DECIMER Python package, but the disadvantage with this option is that the repository won't contain any example of how to load the model from a checkpoint anymore.
  • Update it and add documentation - I guess this is the best solution.

Which images caused the issue? (This is mandatory for images related issues)

No response

Standalone code to reproduce the issue

see #65

or just try running or importing the code in [Predictor_EfficientNet2.py](https://github.com/Kohulan/DECIMER-Image_Transformer/blob/master/DECIMER/Predictor_EfficientNet2.py)

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Kohulan Kohulan linked a pull request Jul 31, 2023 that will close this issue
Kohulan added a commit that referenced this issue Aug 1, 2023
fix: use checkpoints properly for predictions #65 and #66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant