Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git:// no longer supported by GitHub and fails to install #248

Open
mblayman opened this issue Apr 26, 2022 · 1 comment
Open

git:// no longer supported by GitHub and fails to install #248

mblayman opened this issue Apr 26, 2022 · 1 comment

Comments

@mblayman
Copy link
Contributor

mblayman commented Apr 26, 2022

LuaFormatter is failing to install because of a recent change from GitHub. Here's my GitHub Actions job failing to install LuaFormatter.

which lua-format || luarocks --tree .luarocks install --server https://luarocks.org/dev luaformatter
Cloning into 'LuaFormatter'...
fatal: remote error: 
  The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.

Installing https://luarocks.org/dev/luaformatter-scm-1.rockspec
Error: Failed cloning git repository.

https://github.com/mblayman/atlas/runs/6168576509?check_suite_focus=true if the job in context.

I suspect the problem is from https://github.com/Koihik/LuaFormatter/blob/master/luaformatter-scm-1.rockspec#L5. The details about the change are on the GitHub blog.

I think it can be fixed by changing the protocol from git:// to git+https://. I don't know if this will require a new version pushed to LuaRocks.

mblayman added a commit to mblayman/LuaFormatter that referenced this issue Apr 26, 2022
@xbc5
Copy link

xbc5 commented Jul 28, 2022

This might be related to #252.

Also, the rockspec on luarocks still uses the git protocol: https://luarocks.org/manifests/tammela/luaformatter-scm-1.rockspec

@tammela if you could fix this; thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants