Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix parameter binding problem. #130

Merged
merged 3 commits into from Nov 27, 2019
Merged

fix parameter binding problem. #130

merged 3 commits into from Nov 27, 2019

Conversation

nao-kobayashi
Copy link
Contributor

I would be grateful if you could review this pull request.
#128

@Koka
Copy link
Owner

Koka commented Nov 26, 2019

Could you please make tests green?

@coveralls
Copy link

coveralls commented Nov 26, 2019 •
edited

Coverage Status

Coverage increased (+1.7%) to 60.141% when pulling f56e72b on nao-kobayashi:modify-encoded-value into 8e726f4 on Koka:master.

@nao-kobayashi
Copy link
Contributor Author

Sorry for bothering you.
Is this build process stuck?
Am I doing anything wrong?

@Koka
Copy link
Owner

Koka commented Nov 27, 2019

@nao-kobayashi Ah, it's ok, I'm merging this

@Koka Koka merged commit 70d4fb2 into Koka:master Nov 27, 2019
@Koka
Copy link
Owner

Koka commented Nov 27, 2019

Publishing as 0.16.0

@nao-kobayashi
Copy link
Contributor Author

Sorry to rush you. Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nao-kobayashi @Koka @coveralls