Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] Good support for NewComputerModern font #67

Merged
merged 8 commits into from
Jul 22, 2022
Merged

Conversation

Kolaru
Copy link
Owner

@Kolaru Kolaru commented Jul 17, 2022

Reintroduce support for NewComputerModern which as better support for unicode and should have all glyphs we'll ever need.

Should help with #44, #46, #49 and #57.

Require the awesome work of @jkrumbiegel in JuliaGraphics/FreeTypeAbstraction.jl#72 and MakieOrg/Makie.jl#2139

Require some work to avoid reintroducing #26

@Kolaru Kolaru changed the title [draft] Good support NewComputerModern font [draft] Good support for NewComputerModern font Jul 17, 2022
@Kolaru Kolaru marked this pull request as ready for review July 21, 2022 22:21
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2022

Codecov Report

Merging #67 (aa2c7ff) into master (ca57d2b) will decrease coverage by 3.38%.
The diff coverage is 96.77%.

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
- Coverage   81.88%   78.50%   -3.39%     
==========================================
  Files           9        7       -2     
  Lines         508      442      -66     
==========================================
- Hits          416      347      -69     
- Misses         92       95       +3     
Impacted Files Coverage Δ
src/engine/texelements.jl 80.26% <93.75%> (+3.04%) ⬆️
src/engine/fonts.jl 80.00% <100.00%> (+1.05%) ⬆️
src/engine/layout.jl 89.68% <100.00%> (-2.11%) ⬇️
src/parser/commands_registration.jl 34.78% <0.00%> (-49.73%) ⬇️
src/parser/parser.jl 72.60% <0.00%> (-0.19%) ⬇️
src/MathTeXEngine.jl
src/engine/computer_modern_data.jl

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca57d2b...aa2c7ff. Read the comment docs.

@Kolaru
Copy link
Owner Author

Kolaru commented Jul 21, 2022

@jkrumbiegel Everything should be okay, but I didn't manage to run Makie tests with your PR and this one (everytime I forgot or to do it properly x_x). If everything looks fine to you, I'll merge and tag a new version.

@jkrumbiegel
Copy link

Here's a couple refimages. I think it looks mostly good but the x^2 has the 2 very tight on the x now.

Recorded:

image

Reference:

image

Recorded:

image

Reference:

image

@Kolaru
Copy link
Owner Author

Kolaru commented Jul 22, 2022

Thanks a lot for the feedback and the reference image @jkrumbiegel

Merging now.

@Kolaru Kolaru merged commit c757b00 into master Jul 22, 2022
@Kolaru Kolaru deleted the full_unicode_font branch December 30, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants