Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for passing configPath and coverageSummaryPath #3

Merged
merged 5 commits into from
May 24, 2017

Conversation

Koleok
Copy link
Owner

@Koleok Koleok commented May 24, 2017

closes #1 closes #2

@Koleok Koleok merged commit 60bdff3 into master May 24, 2017
@shercoder
Copy link

Hi @Koleok,
I'm having an issue regarding this change. I'm using jest.config.json that defines thresholds as well. After running jest coverage and then ratchet with --configPath=jest.config.json, it adds thresholds to our package.json instead of updating thresholds in our jest.config.json.

Is this intended behavior? or am I doing something wrong running ratchet?

@Koleok
Copy link
Owner Author

Koleok commented Aug 19, 2018

@shercoder First off you are not doing anything wrong, and yes It would make perfect sense for the ratcheted thresholds to be written back to your config file at the specified path.

When I first wrote this I just didn't have a need to handle case of using a jest config file, so I figured I'd just wait around and see if anyone else asked. So this is valuable feedback ✨

I can probably slice off an hour or so and make this change this week thanks for the input 👍

@Koleok Koleok deleted the 1-config-file-arg branch August 19, 2018 03:02
@shercoder
Copy link

@Koleok Hey thanks for replying. Yeah I think it would be very much valuable to add this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow different path for coverage path allow different configuration file
2 participants