-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When scraping Adultdvdempire VOD Scrapes don't pull actors #1353
Comments
Thank you very much for the detailed issue report! I'll have a look in the next few days at this. :) |
The majority of movies exist as DVD and VOD Version on ADE. For multi movie scraping it would be really helpful, if preference could be given to the DVD version in case both exist, since this bug has not been fixed yet. Even if the bug would have been fixed, I would personally prefer to scrape the DVD version in case both exist. |
Ah, ok. Thanks. I forgot about this issue but have added it the v2.8.14 milestone. |
Many thanks for your support! Additionally I noticed, that the release year is not screaped correctly for some VOD movies. Describe the bug To Reproduce Expected behavior MediaElch Version:
Operating System:
|
Hi Andre, Thanks for the update. I will check that as soon as I manage to build the project. One remark regarding the release year topic: DVD example: "Breast Seller 3" from "Third Degree Films" In both cases the release year is not scraped correctly. At the bottom of the page under "Product Information" you can find the "Released" date. However, this is not the production year! Look at "One Night In Los Angeles" from "Dorcel" to see the difference. I believe this is the date, when the movie has been added to the ADE catalogue. So, actually, this is not a bug. ADE simply does not have the production year. However one could think about using the "Released" date from "Product Information" as a fall back option. Regarding actors: Please use the movie @myxtrastufff posted ("50 Shades Of Pink"), then you will see the problem. Kind regards |
Oh! Thank you very much for this insight! In e7063d2 I set the "Released" field for ADE movies the following way:
I hope that this pattern suits your use case. If not, let me know and I'm happy to change it. The movie posted by @myxtrastufff is a good example. I've added test cases to MediaElch to check the ADE scraper for actors for this specific movie. I've also fixed the actor scraping in 2163843 :-) Regards, |
Perfect! Thank you very much!
Awesome! Again many thanks! Would it be possible to get a compiled version with these two fixes? I'm still struggling to compile the project here on my PC. |
@AldanaFan I'm currently building and releasing the next MediaElch version v2.8.14. The full release process takes an hour or two. :-) When it's ready, these links will work: |
Works very well! Thank you :-) |
Describe the bug
When scraping Adultdvdempire VOD or Video on Demand Scrapes don't pull actors. This only appears to be an issue when picking a (VOD) movie not a (DVD) movie. But a lot of movies are only (VOD) movies
To Reproduce
using Adultdvdempire scraper, scrape "50 Shades Of Pink"
No actors are pulled into the tool.
Expected behavior
Actors are added to the tool when scraped. For "50 Shades Of Pink" the below actors are displayed on the site and should be add/pulled into the tool.
Alyssa Divine
Chantelle Fox
Holly Kiss
Seth Strong
Tiffany Naylor
Crystal Coxxx
MediaElch Version:
Operating System:
On version 2.6.4 and 2.6.6 the scraper pulls the first actor but no other actors.
The text was updated successfully, but these errors were encountered: