Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When scraping Adultdvdempire VOD Scrapes don't pull actors #1353

Closed
myxtrastufff opened this issue Jul 28, 2021 · 10 comments
Closed

When scraping Adultdvdempire VOD Scrapes don't pull actors #1353

myxtrastufff opened this issue Jul 28, 2021 · 10 comments

Comments

@myxtrastufff
Copy link

Describe the bug
When scraping Adultdvdempire VOD or Video on Demand Scrapes don't pull actors. This only appears to be an issue when picking a (VOD) movie not a (DVD) movie. But a lot of movies are only (VOD) movies

To Reproduce
using Adultdvdempire scraper, scrape "50 Shades Of Pink"
No actors are pulled into the tool.

Expected behavior
Actors are added to the tool when scraped. For "50 Shades Of Pink" the below actors are displayed on the site and should be add/pulled into the tool.
Alyssa Divine
Chantelle Fox
Holly Kiss
Seth Strong
Tiffany Naylor
Crystal Coxxx

MediaElch Version:

  • [ X] 2.8.12 stable

Operating System:

  • [ X] Windows 10

On version 2.6.4 and 2.6.6 the scraper pulls the first actor but no other actors.

@bugwelle
Copy link
Collaborator

Thank you very much for the detailed issue report! I'll have a look in the next few days at this. :)

@SirCumAlot1988
Copy link

The majority of movies exist as DVD and VOD Version on ADE. For multi movie scraping it would be really helpful, if preference could be given to the DVD version in case both exist, since this bug has not been fixed yet.

Even if the bug would have been fixed, I would personally prefer to scrape the DVD version in case both exist.

@bugwelle bugwelle added this to the v2.8.14 milestone Jan 21, 2022
@bugwelle
Copy link
Collaborator

Ah, ok. Thanks. I forgot about this issue but have added it the v2.8.14 milestone.

@SirCumAlot1988
Copy link

Many thanks for your support!

Additionally I noticed, that the release year is not screaped correctly for some VOD movies.

Describe the bug
When scraping Adultdvdempire VOD movies, the release year is not scraped correctly for some movies. I could not clearly figure out why it works in some cases and in others it doesn't. Maybe this happens, if the actors are not listed on ADE (like in the example below).

To Reproduce
using Adultdvdempire scraper, scrape "Titmania - Booby Style" from "Erotic Pleasure"
The release year is scraped as 2022.

Expected behavior
The release year is displayed on the site and should be 2020.

MediaElch Version:

[ X] 2.8.12 stable

Operating System:

[ X] Windows 10

@bugwelle
Copy link
Collaborator

bugwelle commented Feb 5, 2022

Hi,

with 709801e and e7063d2 MediaElch now correctly scrapes the release date for VOD movies in the search results as well as for the movie details.

Regarding actors on VOD: I didn't find any. The movie @AldanaFan provided does not have any actors as far as I can see.

Regards,
Andre

@SirCumAlot1988
Copy link

SirCumAlot1988 commented Feb 6, 2022

Hi Andre,

Thanks for the update. I will check that as soon as I manage to build the project.

One remark regarding the release year topic:
I realized that the release year is not scraped correctly, if it is not found next to the studio name on the top of the page. This is the case both for DVD and VOD movies.

DVD example: "Breast Seller 3" from "Third Degree Films"
VOD example: "Titmania - Booby Style" from "Erotic Pleasure"

In both cases the release year is not scraped correctly.

At the bottom of the page under "Product Information" you can find the "Released" date. However, this is not the production year! Look at "One Night In Los Angeles" from "Dorcel" to see the difference. I believe this is the date, when the movie has been added to the ADE catalogue. So, actually, this is not a bug. ADE simply does not have the production year. However one could think about using the "Released" date from "Product Information" as a fall back option.

Regarding actors:
Yes, you are right. The movie I posted does not have any actors listed on ADE. It was meant as an example for the release year scraping "bug".

Please use the movie @myxtrastufff posted ("50 Shades Of Pink"), then you will see the problem.

Kind regards

@bugwelle
Copy link
Collaborator

bugwelle commented Feb 6, 2022

However, this is not the production year

Oh! Thank you very much for this insight! In e7063d2 I set the "Released" field for ADE movies the following way:

  1. If there is a Production Year: on the page, use that (under "Product Information" section)
  2. As a fallback, use the Released: entry from that page (under "Product Information" section)

I hope that this pattern suits your use case. If not, let me know and I'm happy to change it.


The movie posted by @myxtrastufff is a good example. I've added test cases to MediaElch to check the ADE scraper for actors for this specific movie. I've also fixed the actor scraping in 2163843 :-)

Regards,
Andre

@SirCumAlot1988
Copy link

In e7063d2 I set the "Released" field for ADE movies the following way:

1. If there is a `Production Year:` on the page, use that (under "Product Information" section)

2. As a fallback, use the `Released:` entry from that page (under "Product Information" section)

Perfect! Thank you very much!

The movie posted by @myxtrastufff is a good example. I've added test cases to MediaElch to check the ADE scraper for actors for this specific movie. I've also fixed the actor scraping in 2163843 :-)

Awesome! Again many thanks! Would it be possible to get a compiled version with these two fixes? I'm still struggling to compile the project here on my PC.

@bugwelle
Copy link
Collaborator

bugwelle commented Feb 6, 2022

@AldanaFan I'm currently building and releasing the next MediaElch version v2.8.14. The full release process takes an hour or two. :-)

When it's ready, these links will work:

@bugwelle bugwelle closed this as completed Feb 6, 2022
@SirCumAlot1988
Copy link

Works very well! Thank you :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants