-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kodi] Update nfo file "version" #516
Comments
Most tags have been updated and are ready to use. I'll move this issue to the v2.6.4 milestone because GUI elements won't be updated for v2.6.2 |
Does this mean that the NFO files will now ultimately be fixed in v2.6.4 instead of v2.6.2? |
This means that MediaElch does not generate invalid (or old) xml tags. For example MediaElch does not allow users to add multiple ratings through the GUI but we will nevertheless use the "new" Kodi syntax which does allow multiple ones: <ratings>
<rating ...>
</rating>
<rating ...>
</rating>
</ratings> We create the code above vor v17/v18 instead of just a single MediaElch is able to read Kodi v17/v18 tags but we cannot show all of them in the GUI, yet. This includes multiple ratings, unique id's other than IMDb and TVDb, the I just don't have enough time to fix this all of this this month. v2.6.0 has been released more than half a year ago and I don't want to postpone the new version any further. :-) #719 is still part of v2.6.2 and I will update all tags that are not compatible with v17 and v18. |
Sounds good. Multiple ratings (e.g. Rotten Tomatoes) would be a great addition for the future.. |
Apart from the "max" attribute, I think the name attribute and value tag needs slight adjustment too. This is how Kodi generates the nfo upon export (multiple files). The name attribute is all lowercase and "value" property has 6 digits after decimal (for accuracy?? not sure..). I know that ME doesn't support multiple ratings right now but I pasted the whole section for completeness.
=======================================
=======================================
======================================= |
Max attribute added for ratings tag. *.nfo files for movies should now be on par with how Kodi (v18.4) does it at this point. |
MediaElch now supports multiple ratings in the UI. |
With the latest Kodi versions, a lot has happened regarding nfo files, e.g.
<rating>
now has amax
attribute and more. We should update our nfo handling.See: https://kodi.wiki/view/NFO_files/Movies
The text was updated successfully, but these errors were encountered: