refactor(MovieScraper): Move to job-based movie loading #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugwelle
force-pushed
the
movie-load
branch
2 times, most recently
from
50199a7
to
daff284
Compare
|
TODO:
|
bugwelle
force-pushed
the
movie-load
branch
2 times, most recently
from
43fdd62
to
68ac996
Compare
bugwelle
force-pushed
the
movie-load
branch
4 times, most recently
from
2b300d7
to
f992df9
Compare
bugwelle
force-pushed
the
movie-load
branch
3 times, most recently
from
ee18a68
to
8d56634
Compare
bugwelle
force-pushed
the
movie-load
branch
2 times, most recently
from
f4aa73d
to
965dd46
Compare
bugwelle
force-pushed
the
movie-load
branch
2 times, most recently
from
113a1bd
to
efef226
Compare
|
Ok, so far I think I've implemented everything. Now I need to do some testing:
|
bugwelle
force-pushed
the
movie-load
branch
4 times, most recently
from
c4c321e
to
48c0db6
Compare
bugwelle
force-pushed
the
movie-load
branch
3 times, most recently
from
0ab84ad
to
62e7e6e
Compare
bugwelle
force-pushed
the
movie-load
branch
3 times, most recently
from
9cf82dc
to
87546b9
Compare
Just like for TV scrapers, move to a job based movie scraper interface. This will make it possible (in the future) to have preview windows in movie search dialogs or parallel scraping (which previously didn't work properly).
bugwelle
changed the title
This was referenced May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like for TV scrapers. This will allow us to have parallel scraping, parallel searches and fewer race conditions that would be possible if we move scraping to a background process (like changing the scraper's language in the settings during scraping).
Should fix: