Code Intelligence Fails with Multiple Definitions of Same Function

[aaroncampbell]

Short Summary

I work on a lot of WordPress projects. There are certain functions that exist in multiple places, usually where one instance is a stub. For example, add_filter exists as a stub with no parameters in wp-admin/includes/noop.php (each function here has an @ignore comment) and the actual (oft used) function is in wp-includes/plugin.php. When you type add_filter( you get no parameters offered.

There are quite a few more functions that suffer from this. Including many that are in wp-includes/pluggable.php which aren't overridden in core but are often overridden in a given project (these are each wrapped in a function_exists check and loaded later than other files.

Steps to Reproduce

• Start a WordPress project
• Open a file and type add_filter(

Expected results

Actual results

Platform Information

Komodo IDE, version 10.0.0, build 89159, platform linux-x86_64
Specifically running Ubuntu 16.04

[aaroncampbell]

I'm sure there are other projects that suffer from the same kind of issues, but WordPress is what I work in every day (and is wildly popular) so it's what I used as an example.

[mitchell-as]

Thanks for the report. I'm going to have to investigate whether or not this is feasible in a reasonable amount of time. The milestone is for planning purposes.

[seattledeveloper]

I have another use case that might be helpful to add.

I have a project that has customized session management. There are several login locations for different classes of users, each with different PHP files with slightly different versions of functions with the same name, each file located relative to it's own login area.

It would be nice if code intelligence could work based on the files actually included within the file being edited, but this might be way too big an undertaking. I'm not saying or implying that I need this feature for myself, just wanted to add another example.

Cheers!

[mitchell-as]

I believe the proper course of action here is to ignore storing functions with the @ignore tag or prevent them from being valid "hits".

[Naatan]

@mitchell-as would Wordpress' functions fall under that new logic?

[mitchell-as]

Yeah, my conclusion comes from analyzing a wordpress project.

[Naatan]

Perfect :)