Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSX support: doesn't highlight syntax errors AT ALL! #1988

Closed
rulatir opened this issue Sep 1, 2016 · 5 comments
Closed

JSX support: doesn't highlight syntax errors AT ALL! #1988

rulatir opened this issue Sep 1, 2016 · 5 comments

Comments

@rulatir
Copy link

rulatir commented Sep 1, 2016

Short Summary

It seems that JSX support has brutally removed JavaScript syntax checking.

Steps to Reproduce

  1. Write a .js file with outrageous syntax errors.
  2. Note that the errors are properly undersquiggled.
  3. Switch the file's language to JSX

Expected results

The outrageous syntax errors should still be undersquiggled.

Actual results

No syntax errors are underdsquiggled at all. The realtime assistance that syntax error detection normally provides is completely sacrificed.

Platform Information

Komodo Edit or IDE? Edit
Komodo Version? 10.1
Operating System (and version)? Linux 64bit

@mitchell-as
Copy link
Contributor

Would you please provide a concrete example? I used the string

this is totally invalid syntax;

In JS I get two syntax errors:

  1. Expected an assignment or function call and instead saw an expression.
  2. Missing semicolon.

In JSX I get one syntax error:

  1. Unexpected identifier (on column 6).

While the errors are different (JSHint vs. JSXHint), it is not the case that syntax errors aren't highlighted at all.

@dorklord23
Copy link

@mitchell-as, I've done as you said and Komodo Edit 11 didn't detect anything wrong

@dorklord23
Copy link

image

@Naatan
Copy link
Member

Naatan commented Oct 5, 2017

Make sure you have jsxhint installed and configured:

image

@Naatan
Copy link
Member

Naatan commented Oct 5, 2017

Also please file a new bug if you continue to see this issue. You are responding to a year old closed bug.

@Komodo Komodo locked and limited conversation to collaborators Oct 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants