Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundles vulnerable copy of Expat - please update to 2.2.2 #2659

Closed
hartwork opened this issue Jun 19, 2017 · 6 comments
Closed

Bundles vulnerable copy of Expat - please update to 2.2.2 #2659

hartwork opened this issue Jun 19, 2017 · 6 comments

Comments

@hartwork
Copy link

hartwork commented Jun 19, 2017

Hi!

This repository bundles an outdated vulnerable copy of Expat 1.95.8. Please update your copy to version 2.2.2 with the latest security fixes. A change log with details is available at https://github.com/libexpat/libexpat/blob/master/expat/Changes . Thank you!

Best

 
Sebastian

@Naatan
Copy link
Member

Naatan commented Jun 19, 2017

Thanks for reporting.

@mitchell-as
Copy link
Contributor

After internal discussion, the action item is to switch from cElementTree (which bundles the old version of expat in question) to the Python stdlib's cElementTree, which should have more security updates.

@hartwork
Copy link
Author

hartwork commented Jun 20, 2017

Wouldn't that bundle Expat as well? Or is this about a new no-bundle dependency? Also, Python itself still needs to update their bundle of Expat. I'd be curious about more details.

@mitchell-as
Copy link
Contributor

Yes, but we off-load the maintenance duty to Python since Python includes the cElementTree module (which houses the out-dated expat you found) in its stdlib.

Komodo pre-dates Python 2.5, so it had to bundle an external, 3rd-party, C-based XML parser. Python 2.5 started including that parser in its standard library, but Komodo never shifted to using Python's version. This dependency is unnecessary.

@hartwork
Copy link
Author

I see. As long as you keep the Python bundle up to date, I'm happy :)

@hartwork hartwork changed the title Bundles vulnerable copy of Expat - please update to 2.2.1 Bundles vulnerable copy of Expat - please update to 2.2.2 Jul 14, 2017
@Naatan Naatan modified the milestones: 11.1, 11 Aug 25, 2017
@mitchell-as
Copy link
Contributor

Komodo uses Python 2.7, which has updated their version of Expat (see https://bugs.python.org/issue30694). As mentioned previously in this ticket, the original reference to the old Expat you found is no longer used -- it's there as a legacy reference.

Closing ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants