Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files created based on templates are detected as Text files #3092

Closed
mjainQA opened this issue Sep 14, 2017 · 2 comments
Closed

Files created based on templates are detected as Text files #3092

mjainQA opened this issue Sep 14, 2017 · 2 comments
Assignees
Milestone

Comments

@mjainQA
Copy link

mjainQA commented Sep 14, 2017

Short Summary

Files created based on templates are detected as Text files.

Steps to Reproduce

  1. Right click on the folder in places pane -> New File from Template
  2. Select PHP template from Commando
  3. Enter filename without extension for e.g. test
  4. Click ok
  5. Notice that file 'test' is detected as text file. See screenshot

Expected results

Actual results

Platform Information

Komodo Edit or IDE?
Komodo Version?
Operating System (and version)?
Komodo IDE, version 11.0.0, build 90665, platform macosx.
Built on Wed Sep 13 19:50:11 2017.

Additional Information

image

@Naatan
Copy link
Member

Naatan commented Sep 15, 2017

I can't help how it is detected in your side pane, as this is based on the file extension and reading the file to find out the real type would significantly slow down side pane loading. But the language ought to definitely be set properly.

@Naatan Naatan self-assigned this Sep 15, 2017
@Naatan Naatan added this to the 11.0.1 milestone Sep 15, 2017
@Naatan Naatan modified the milestones: 11.0.1, 11.1 Sep 29, 2017
@th3coop th3coop assigned th3coop and unassigned Naatan Jan 15, 2018
@th3coop
Copy link
Member

th3coop commented Mar 16, 2018

This has been buried in the views code for a while now. It's amazing it never was hit before. That code was a bit of a mess: https://github.com/Komodo/KomodoIDE/commit/7ab16f6171e3efdbd514c5a0b29d6f25b2ed649f

@th3coop th3coop closed this as completed Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants