Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP8 way of Python code commenting. '#' -> '# ' #8

Merged
merged 1 commit into from
Oct 14, 2014
Merged

PEP8 way of Python code commenting. '#' -> '# ' #8

merged 1 commit into from
Oct 14, 2014

Conversation

adriank
Copy link
Contributor

@adriank adriank commented Oct 12, 2014

PEP8 recommends to comment using # + space. While it is just a style guide, code quality tools like landscape.io raise style problems when not followed resulting in very poor score. Changing '#' to '# ' made my project ObjectPath (ca. 1500 lines) score better by 4% there.

PEP8 recommends to comment using # + space. While it is just a style guide, code quality tools like landscape.io raise style problems when not followed resulting in very poor score. Changing '#' to '# ' made my project ObjectPath (ca. 1500 lines) score better by 4% there.
toddw-as pushed a commit that referenced this pull request Oct 14, 2014
PEP8 way of Python code commenting. '#' -> '# '
@toddw-as toddw-as merged commit 8c3626d into Komodo:8.5.4 Oct 14, 2014
@toddw-as
Copy link
Contributor

Thanks - this might annoy a few people (existing users), but I think they'll get use to it.

@toddw-as
Copy link
Contributor

Oh, btw, I think this meant to go into the "trunk" (master) branch:
commit acedf5e

@adriank
Copy link
Contributor Author

adriank commented Oct 14, 2014

Thanks!

BTW, It didn't let me submit a pull request for master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants