Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get icons from coins repo at build time #2194

Merged
merged 2 commits into from Jan 9, 2023
Merged

Get icons from coins repo at build time #2194

merged 2 commits into from Jan 9, 2023

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Jan 7, 2023 •
edited

closes #2037
To test:

  • load app
  • confirm all coin logos are present

Note: until KomodoPlatform/coins#610 is merged, the icons in addressbook for network standard address input will not be present.

@smk762 smk762 marked this pull request as draft January 7, 2023 12:38
@smk762 smk762 mentioned this pull request Jan 7, 2023
Merged
@smk762 smk762 marked this pull request as ready for review January 7, 2023 12:59
cipig
cipig approved these changes Jan 7, 2023
View reviewed changes
Copy link
Member

@cipig cipig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, all icons are still present

Canialon
Canialon approved these changes Jan 8, 2023
View reviewed changes
Copy link
Contributor

@Canialon Canialon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All icons display good on macos, except icons in addressbook for network standard address as expected

@smk762 smk762 merged commit bd59e40 into dev Jan 9, 2023
@smk762 smk762 deleted the source_coins_icons branch January 9, 2023 10:24
This was referenced Mar 4, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipig cipig cipig approved these changes

@Canialon Canialon Canialon approved these changes

@SirSevenG SirSevenG Awaiting requested review from SirSevenG

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR]: Source missing icons from coins repo on build
3 participants
@smk762 @cipig @Canialon