Add SLP UTXOs validation using BCHD API. #1094
Conversation
mm2src/coins/utxo/bch.rs
Outdated
| fn my_public_key(&self) -> &Public { self.utxo_arc.key_pair.public() } | ||
| fn my_public_key(&self) -> &Public { | ||
| let public = self.utxo_arc.key_pair.public(); | ||
| println!("{:?}", public); |
There was a problem hiding this comment.
I guess it's not used anymore :)
There was a problem hiding this comment.
True, I forgot to remove it after debugging 🙂 I will push the fix shortly.
mm2src/coins/utxo/bchd_grpc.rs
Outdated
| impl From<GrpcWebMultiUrlReqErr> for CheckSlpTransactionErr { | ||
| fn from(err: GrpcWebMultiUrlReqErr) -> Self { | ||
| CheckSlpTransactionErr { | ||
| // url is already present in the GrpcWebMultiUrlReqErr |
There was a problem hiding this comment.
How about cloning the url? We may remove the CheckSlpTransactionErr::kind field someday and forget to fill CheckSlpTransactionErr::to_url.
There was a problem hiding this comment.
Ok, that's actually good to have a bit of redundancy.
mm2src/coins/utxo/slp.rs
Outdated
| @@ -1,18 +1,23 @@ | |||
| /// https://slp.dev/ | |||
There was a problem hiding this comment.
It looks like a doc comment related to the import below :D
There was a problem hiding this comment.
I will add more info for clarity 🙂
There was a problem hiding this comment.
Approved! Only one non-blocking comment in addition to @sergeyboyko0791 comments.
|
@sergeyboyko0791 I've pushed commit with fixes. Could you please review the PR again? 🙂 |
#701