Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use komodod multiarch Docker image in tests. Do not build and upload libmm2 for desktop. #1214

Merged
merged 6 commits into from Feb 17, 2022
Merged

Use komodod multiarch Docker image in tests. Do not build and upload libmm2 for desktop. #1214

merged 6 commits into from Feb 17, 2022

Conversation

artemii235
Copy link
Member

@artemii235 artemii235 commented Feb 15, 2022 •
edited

@artemii235 artemii235 changed the title Opened to trigger CI. Not ready for review. Use komodod multiarch Docker image in tests. Feb 16, 2022
@artemii235
Copy link
Member Author

@sergeyboyko0791 @shamardy @Milerius It's ready for review.

@artemii235 artemii235 changed the title Use komodod multiarch Docker image in tests. Use komodod multiarch Docker image in tests. Do not build and upload libmm2 for desktop. Feb 16, 2022
sergeyboyko0791
sergeyboyko0791 reviewed Feb 16, 2022
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only questions :D

azure-pipelines-build-stage-job.yml Show resolved Hide resolved
azure-pipelines-build-stage-job.yml Show resolved Hide resolved
mm2src/docker_tests/docker_tests_common.rs Show resolved Hide resolved
sergeyboyko0791
sergeyboyko0791 approved these changes Feb 17, 2022
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@artemii235 artemii235 merged commit e7a1ce9 into dev Feb 17, 2022
@artemii235 artemii235 deleted the komodod-docker-multiarch branch February 17, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Milerius Milerius Milerius approved these changes

@shamardy shamardy shamardy approved these changes

@sergeyboyko0791 sergeyboyko0791 sergeyboyko0791 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@artemii235 @Milerius @shamardy @sergeyboyko0791