Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unstable test_update_maker_order_fail test #1216

Merged
merged 1 commit into from Feb 17, 2022
Merged

Fix unstable test_update_maker_order_fail test #1216

merged 1 commit into from Feb 17, 2022

Conversation

shamardy
Copy link
Collaborator

fixes #1215

@shamardy
Copy link
Collaborator Author

There seems to be a problem with the eth_getTransactionByHash method causing some of the eth_tests to fail.

@artemii235
Copy link
Member

There seems to be a problem with the eth_getTransactionByHash method causing some of the eth_tests to fail.

There was a temporary outage of the single RPC node. Seems ok now.

artemii235
artemii235 approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@artemii235 artemii235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the prompt fix!

sergeyboyko0791
sergeyboyko0791 approved these changes Feb 17, 2022
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@artemii235 artemii235 merged commit 973ab4c into dev Feb 17, 2022
@artemii235 artemii235 deleted the fix-unstable-update-maker-order-fail-test branch February 17, 2022 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemii235 artemii235 artemii235 approved these changes

@Milerius Milerius Milerius approved these changes

@sergeyboyko0791 sergeyboyko0791 sergeyboyko0791 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shamardy @artemii235 @Milerius @sergeyboyko0791