[r2r] Implement ARRR swap in light mode. #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…red SaplingSyncConnector.
added 4 commits
June 7, 2022 14:21
# Conflicts: # Cargo.lock # mm2src/coins/Cargo.toml # mm2src/common/Cargo.toml
artemii235
changed the title
|
@sergeyboyko0791 @ozkanonur @shamardy Thanks for your notes! It’s ready for the next review iteration. |
added 2 commits
June 9, 2022 17:39
# Conflicts: # mm2src/coins/eth.rs # mm2src/coins_activation/src/z_coin_activation.rs # mm2src/db_common/src/sqlite.rs
artemii235
changed the title
added 2 commits
June 13, 2022 15:49
# Conflicts: # mm2src/mm2_test_helpers/src/for_tests.rs
artemii235
changed the title
Comment on lines
870
to
871
| let maker_coin_htlc_key_pair = self.maker_coin.derive_htlc_key_pair(self.uuid.as_bytes()); | ||
| let taker_coin_htlc_key_pair = self.taker_coin.derive_htlc_key_pair(self.uuid.as_bytes()); |
There was a problem hiding this comment.
Can't self.unique_swap_data() be used here instead of self.uuid.as_bytes()?
onur-ozkan
previously approved these changes
Jun 14, 2022
artemii235
changed the title
artemii235
changed the title
|
@sergeyboyko0791 Last review notes fixed :) |
sergeyboyko0791
approved these changes
Jun 14, 2022
laruh
pushed a commit
that referenced
this pull request
Jun 16, 2022
* WIP. Fetched ZOMBIE compact blocks cache. * WIP building wallet DB for ZOMBIE. * WIP. Balance is shown incorrectly. * WIP. Got correct balance for ZOMBIE address from lightwalletd. * WIP. * Sent shielded transaction using light mode. * WIP. * ZcoinLightClient WIP. * WIP. Compilation fails. Saving dev state. * WIP. Deleted some unneeded code. * Cherry-pick from arrr-light-mode-experiments. * WIP. * WIP. Minor changes. * WIP. * WIP Zcoin light mode activation. * WIP Activated ZOMBIE in light mode. Got correct balance. * WIP. Working on withdraw. * WIP. Optimized SQLite. Added withdraw ZOMBIE test. * WIP. Got valid transaction from withdraw in light mode and broadcast it. * WIP. Implementing light wallet sync state handling using channels. * WIP. More refactoring. * WIP. * WIP. * WIP. Compilation fails. * WIP. Temporary Clippy fixes. Withdraw works. * Fix WASM. * WIP. Implementing state sync. * WIP. Added SaplingSyncStateConnector. * WIP. Added SaplingSyncRespawnHandle, SaplingSyncRespawnGuard, refactored SaplingSyncConnector. * WIP. Did the first RICK/ZOMBIE light mode swap. * WIP. Error handling. * WIP. Error handling. Removed unused code. * WIP. Trying AES. * WIP. Deriving HTLC privkeys. Compilation fails. * Finished HTLC privkeys derivation refactoring. * WIP. Checking lightwalletd response when tx does not exist. * Add watch_for_tx existence check in sync loop. Add ticker to activation response. * Fix WASM. * Fixes after merge. * Change HTLC private keys derivation algo for Zcoin. * Refactor to fix clippy::too_many_arguments. * Fix tests. * Replace block_in_place with async_blocking if required. * Update tonic, remove some deps duplicates. * WIP. * Refactor tests a bit, ignore long-running ones. * Disable blocks_cache_path for wasm32 arch. * Fix tests compilation. * More info about sync progress in init_z_coin_status. * A bit more refactoring. * Leave notes on how the light wallet state sync works. * Last minor changes. * Cargo.lock updated. * Fix review notes. * Fixes after merge. * One more fix (udeps). * Fix after merge. * WIP. Fixing review notes. * Use unique_swap_data() in try_spend_taker_payment. * Fix review notes. Co-authored-by: Artem Vitae <artem@vitae.com> Co-authored-by: Artem Vitae <email@not.set>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#927
Please note that there are few TODOs for the next iteration.
Also, native client doesn't work now and tx history is not available.