[r2r] Get rid of fomat, wite macros #1316
Conversation
|
I think there is no reason to get rid of If we decide to replace our custom logger (as I described above) with the log crate at all, we won't be able to print emotions. |
sergeyboyko0791
requested review from
artemii235 and
shamardy
and removed request for
artemii235 and
shamardy
* Remove unused code from `commmon.rs`
* Remove `for_c.rs`
sergeyboyko0791
force-pushed
the
fomat-refactoring
branch
from
3f71cdd
to
21b1ed4
Compare
sergeyboyko0791
changed the title
mm2src/common/log.rs
Outdated
| .unwrap(); | ||
| $crate::log::chunk2log(buf, $crate::log::LogLevel::Info) | ||
| let time = $crate::log::short_log_time($crate::now_ms()); | ||
| let file = ::gstuff::filename (file!()); |
There was a problem hiding this comment.
Can we maybe also remove gstuff usage here? 🙂
There was a problem hiding this comment.
It's used in many places. Do you suggest moving it to common crate?
There was a problem hiding this comment.
@sergeyboyko0791 Possibly, or even use https://doc.rust-lang.org/stable/std/path/struct.Path.html#method.file_name if it matches our needs.
There was a problem hiding this comment.
I think gstuff::filename is much more efficient than Path::file_name, because it's based on two operations:
- Find last
/or\in the string slice - Checks if it's needed to return a slice without
.rssuffix
My benchmarks:
gstuff::filename, 1000 iterations: 349.083µs
Path::file_name, 1000 iterations: 1.693791ms
gstuff::filename, 10000 iterations: 4.311166ms
Path::file_name, 10000 iterations: 19.391583ms
How about moving gstuff::filename function to common.rs?
There was a problem hiding this comment.
How about moving gstuff::filename function to common.rs?
Ok :)
* Use `log` macro on `mm2_main`
commmon.rsfor_c.rs