[r2r] Remove outdated transactions from transaction history #1328
Conversation
caglaryucekaya
changed the title
There was a problem hiding this comment.
Thanks for the PR!
It's a first review. @caglaryucekaya Please also check if the same should be done for my_tx_history_v2.
caglaryucekaya
changed the title
…dated transactions
mm2src/coins/utxo/utxo_common.rs
Outdated
| @@ -2056,7 +2056,8 @@ where | |||
| }; | |||
| let mut history_map: HashMap<H256Json, TransactionDetails> = history | |||
| .into_iter() | |||
| .map(|tx| (H256Json::from(tx.tx_hash.as_bytes()), tx)) | |||
| .filter(|tx| H256Json::from_str(&tx.tx_hash).is_ok()) | |||
| .map(|tx| (H256Json::from_str(&tx.tx_hash).unwrap(), tx)) | |||
There was a problem hiding this comment.
There was an unexpected bug here at the creation of the history_map. Using H256Json::from(tx.tx_hash.as_bytes()) created a different hash than the hashes inside the tx_ids vector. As a result, existing transactions in the history_map were ignored and all the transactions in the tx_ids were inserted repeatedly into the history_map. Creating the H256 by H256Json::from_str(&tx.tx_hash) fixed the problem.
caglaryucekaya
changed the title
caglaryucekaya
changed the title
caglaryucekaya
changed the title
…move-outdated-txs
|
@sergeyboyko0791 Could you please take a look too? :) |
|
If everything is fine, I can apply the same change to other coins as well before merging the PR |
|
I think we have the same bug in QRC20, and we also need to remove outdated transactions from from QRC20 tx history.
|
caglaryucekaya
changed the title
caglaryucekaya
dismissed stale reviews from sergeyboyko0791 and artemii235
via
d01a4f9
QRC20 didn't have the same bug, but tx history v2 did so I also fixed it |
caglaryucekaya
changed the title
caglaryucekaya
changed the title
caglaryucekaya
changed the title
Fixes #1321 for UTXO coins by removing outdated transactions from transaction history