Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r2r] Implement tx history RPC for Zcoin (ARRR). #1336

Merged
merged 13 commits into from Jul 18, 2022
Merged

[r2r] Implement tx history RPC for Zcoin (ARRR). #1336

merged 13 commits into from Jul 18, 2022

Conversation

artemii235
Copy link
Member

No description provided.

@artemii235 artemii235 marked this pull request as ready for review July 11, 2022 08:25
@artemii235 artemii235 changed the title [wip] Implement tx history RPC for Zcoin (ARRR). [r2r] Implement tx history RPC for Zcoin (ARRR). Jul 11, 2022
onur-ozkan
onur-ozkan requested changes Jul 13, 2022
View reviewed changes
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!. First review iteration.

mm2src/coins/my_tx_history_v2.rs Outdated Show resolved Hide resolved
mm2src/coins/my_tx_history_v2.rs Outdated Show resolved Hide resolved
@artemii235 artemii235 requested a review from laruh July 13, 2022 11:26
shamardy
shamardy reviewed Jul 13, 2022
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! First review iteration with some suggestions and inquiries.

mm2src/mm2_test_helpers/src/for_tests.rs Outdated Show resolved Hide resolved
mm2src/coins/z_coin.rs Show resolved Hide resolved
mm2src/coins/z_coin.rs Show resolved Hide resolved
mm2src/coins/z_coin.rs Outdated Show resolved Hide resolved
@shamardy shamardy mentioned this pull request Jul 13, 2022
Merged
@artemii235 artemii235 changed the title [r2r] Implement tx history RPC for Zcoin (ARRR). [wip] Implement tx history RPC for Zcoin (ARRR). Jul 14, 2022
@artemii235 artemii235 changed the title [wip] Implement tx history RPC for Zcoin (ARRR). [r2r] Implement tx history RPC for Zcoin (ARRR). Jul 14, 2022
shamardy
shamardy approved these changes Jul 14, 2022
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

onur-ozkan
onur-ozkan approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, lgtm 🔥

@artemii235 artemii235 merged commit 68bbddc into dev Jul 18, 2022
@artemii235 artemii235 deleted the arrr-tx-history-and-native-mode branch July 18, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamardy shamardy shamardy approved these changes

@onur-ozkan onur-ozkan onur-ozkan approved these changes

@sergeyboyko0791 sergeyboyko0791 Awaiting requested review from sergeyboyko0791

@laruh laruh Awaiting requested review from laruh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@artemii235 @shamardy @onur-ozkan