Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't respond to GetKnownPeers p2p msg if the number of peers requested exceeds the default number #1445

Merged
merged 2 commits into from
Aug 16, 2022
Merged

Don't respond to GetKnownPeers p2p msg if the number of peers requested exceeds the default number #1445

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3013de
return random known peers with a maximum of DEFAULT_PEERS_NUM
shamardy Aug 16, 2022
51466ca
Do not respond to GetKnownPeers p2p msg if requested number is greate…
shamardy Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions mm2src/mm2_libp2p/src/peers_exchange.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,10 @@ impl NetworkBehaviourEventProcess<RequestResponseEvent<PeersExchangeRequest, Pee
RequestResponseEvent::Message { message, peer } => match message {
RequestResponseMessage::Request { request, channel, .. } => match request {
PeersExchangeRequest::GetKnownPeers { num } => {
// Should not send a response in such case
if num > DEFAULT_PEERS_NUM {
return;
}
let response = PeersExchangeResponse::KnownPeers {
peers: self.get_random_known_peers(num),
};
Expand Down