[r2r] Port tendermint HTTP RPC client to use webpki roots instead of native.

[artemii235]

#1545

[onur-ozkan]

What do you think about making this change on fork repository? That way we sync with the updates of the upstream repository easier and of course also mm2 codebase will not grow from this change.

[artemii235]

@ozkanonur I have thought about it, but then I noticed that many duplicated deps were removed from Cargo.lock after porting the implementation. Ideally, we would require to update the deps in our fork too. And in case of upstream update, we might have conflicts and duplicates again.

Eventually, we are required to compile less code at the cost of slightly enlarging our own code base. Maintenance cost of either solution look quite similar to me.

And it is just HTTP client - all structures are still imported from external crates. Btw, maybe we can ask tendermint-rs developers to export Client trait even if http-client feature is not enabled :) Currently, users of the lib can't implement their own client without compiling the sample implementation with all the deps.

[onur-ozkan]

Btw, maybe we can ask tendermint-rs developers to export Client trait even if http-client feature is not enabled :) Currently, users of the lib can't implement their own client without compiling the sample implementation with all the deps.

This could solve all the problems actually.

[onur-ozkan]

🔥

[laruh]

Great job!
Yeah, asking tendermint developers is a good idea.