sec fixes, build-time optimizations, dependency optimizations, CI migration, etc #1699

onur-ozkan · 2023-03-07T14:51:19Z

The PR provides:

Less compilation time
Less size on binary builds
Disables solana completely if the feature isn't provided in build(which is disabled by default)
Fixes some of the advisory IDs
Tests are seperated to multiple steps which provides async execution on CI
All pipelines will be executed in async way without blocking each other(except container building/pushing, ssh connections, etc)
Updated Jemalloc flags
CI now checks lint rules for all targets
Fixed all the lint warnings on wasm and tests
More platform support on build targets from CI
CI migration from Azure to Github Actions

Don't forget to squash the commits when merging this.

Resolves #1663

Signed-off-by: ozkanonur <work@onurozkan.dev>

…p-work Signed-off-by: ozkanonur <work@onurozkan.dev>

Signed-off-by: ozkanonur <work@onurozkan.dev>

…p-work Signed-off-by: ozkanonur <work@onurozkan.dev>

Signed-off-by: ozkanonur <work@onurozkan.dev>

…p-work Signed-off-by: ozkanonur <work@onurozkan.dev>

Signed-off-by: ozkanonur <work@onurozkan.dev>

…p-work Signed-off-by: ozkanonur <work@onurozkan.dev>

Signed-off-by: ozkanonur <work@onurozkan.dev>

…p-work

Signed-off-by: ozkanonur <work@onurozkan.dev>

ca333

sec code reviewed @ 78d3307

ca333 · 2023-03-16T08:12:36Z

mm2src/coins/Cargo.toml

 byteorder = "1.3"
 bytes = "0.4"
 cfg-if = "1.0"
 chain = { path = "../mm2_bitcoin/chain" }
 common = { path = "../common" }
 cosmrs = { version = "0.7", default-features = false }
-crossbeam = "0.7"
+crossbeam = "0.8"


cc @DeckerSU

ca333 · 2023-03-16T08:13:21Z

mm2src/coins/Cargo.toml

@@ -144,5 +151,5 @@ winapi = "0.3"
 mm2_test_helpers = { path = "../mm2_test_helpers" }

 [build-dependencies]
-prost-build = { version = "0.10.3", default-features = false }
+prost-build = { version = "0.10.4", default-features = false }


ca333 · 2023-03-16T08:13:51Z

mm2src/coins/Cargo.toml

+bincode = { version = "1.3.3", default-features = false, optional = true }
+ed25519-dalek-bip32 = { version = "0.2.0", default-features = false, optional = true }


cc @DeckerSU

fyi we already had these. I suggest to check Cargo.lock diff for more clear information about dependency changes

Signed-off-by: ozkanonur <work@onurozkan.dev>

…p-work

Signed-off-by: ozkanonur <work@onurozkan.dev>

shamardy

Thank you for the amazing work 🚀 !
Only one non-blocker related to change logs :)

CHANGELOG.md

Signed-off-by: ozkanonur <work@onurozkan.dev>

onur-ozkan added 7 commits March 7, 2023 14:21

upgrade crossbeam from vulnerable version

44c6397

Signed-off-by: ozkanonur <work@onurozkan.dev>

disable solana

f8bf71e

Signed-off-by: ozkanonur <work@onurozkan.dev>

save dev state

ce99a1c

Signed-off-by: ozkanonur <work@onurozkan.dev>

save dev state

6b721e0

Signed-off-by: ozkanonur <work@onurozkan.dev>

update jemalloc config, enable share-generics nightly feat, use lld

1a3bc45

Signed-off-by: ozkanonur <work@onurozkan.dev>

comment out lld configs

c4305a1

Signed-off-by: ozkanonur <work@onurozkan.dev>

Merge branch 'dev' of github.com:KomodoPlatform/atomicDEX-API into de…

e179834

…p-work Signed-off-by: ozkanonur <work@onurozkan.dev>

onur-ozkan changed the title ~~[wip] sec fixes, build-time optimizations, dependency optimizations, etc~~ [wip] sec fixes, build-time optimizations, dependency optimizations, CI migration, etc Mar 8, 2023

create check, fmt, lint multi-os pipelines

667e976

Signed-off-by: ozkanonur <work@onurozkan.dev>

onur-ozkan force-pushed the dep-work branch 2 times, most recently from 55358c5 to b08ecc1 Compare March 8, 2023 13:47

Merge branch 'dev' of github.com:KomodoPlatform/atomicDEX-API into de…

34be3ac

…p-work Signed-off-by: ozkanonur <work@onurozkan.dev>

onur-ozkan force-pushed the dep-work branch from e47def7 to 34be3ac Compare March 8, 2023 13:49

onur-ozkan added 8 commits March 8, 2023 19:15

improve checks for x86

da636a2

Signed-off-by: ozkanonur <work@onurozkan.dev>

Merge branch 'dev' of github.com:KomodoPlatform/atomicDEX-API into de…

1f73e89

…p-work Signed-off-by: ozkanonur <work@onurozkan.dev>

update pipeline

1ac04ed

Signed-off-by: ozkanonur <work@onurozkan.dev>

Merge branch 'dev' of github.com:KomodoPlatform/atomicDEX-API into de…

7b283d0

…p-work Signed-off-by: ozkanonur <work@onurozkan.dev>

exclude check step

0bbfc4e

Signed-off-by: ozkanonur <work@onurozkan.dev>

update pipeline

c110fce

Signed-off-by: ozkanonur <work@onurozkan.dev>

add wasm lint step

98d0594

Signed-off-by: ozkanonur <work@onurozkan.dev>

improvide wasm stack and add wasm pipeline

0058f71

Signed-off-by: ozkanonur <work@onurozkan.dev>

onur-ozkan force-pushed the dep-work branch from 68f9af0 to 0058f71 Compare March 9, 2023 10:12

onur-ozkan added 2 commits March 9, 2023 18:13

initialize build workflow

a3b3cba

Signed-off-by: ozkanonur <work@onurozkan.dev>

increase fmt & lint CI timeout

11091bf

Signed-off-by: ozkanonur <work@onurozkan.dev>

onur-ozkan force-pushed the dep-work branch 6 times, most recently from 566b91e to e898587 Compare March 10, 2023 15:50

ca333 added the under review label Mar 16, 2023

ca333 requested a review from DeckerSU March 16, 2023 08:16

onur-ozkan changed the title ~~[wip] sec fixes, build-time optimizations, dependency optimizations, CI migration, etc~~ [blocked] sec fixes, build-time optimizations, dependency optimizations, CI migration, etc Mar 16, 2023

onur-ozkan changed the title ~~[blocked] sec fixes, build-time optimizations, dependency optimizations, CI migration, etc~~ sec fixes, build-time optimizations, dependency optimizations, CI migration, etc Mar 16, 2023

onur-ozkan added the blocked requires additional attention label Mar 16, 2023

onur-ozkan added 2 commits March 17, 2023 14:09

Merge branch 'dev' of github.com:KomodoPlatform/atomicDEX-API into de…

1391e8e

…p-work

add changelog entries

78d3307

Signed-off-by: ozkanonur <work@onurozkan.dev>

onur-ozkan force-pushed the dep-work branch from 126eaa7 to 78d3307 Compare March 17, 2023 11:13

ca333 previously approved these changes Mar 20, 2023

View reviewed changes

onur-ozkan dismissed ca333’s stale review via 2a77c70 March 20, 2023 16:42

test

6c706ce

Signed-off-by: ozkanonur <work@onurozkan.dev>

onur-ozkan force-pushed the dep-work branch 3 times, most recently from d9fc126 to 6c706ce Compare March 20, 2023 16:51

Merge branch 'dev' of github.com:KomodoPlatform/atomicDEX-API into de…

e9f1265

…p-work

onur-ozkan force-pushed the dep-work branch 2 times, most recently from 5938550 to 5b99b98 Compare March 20, 2023 22:01

implement build uploads from CI

d084b62

Signed-off-by: ozkanonur <work@onurozkan.dev>

onur-ozkan force-pushed the dep-work branch from c5941f3 to d084b62 Compare March 20, 2023 22:55

onur-ozkan removed the blocked requires additional attention label Mar 20, 2023

onur-ozkan added 2 commits March 21, 2023 11:31

build dylib for x86-64 mac

72e9819

Signed-off-by: ozkanonur <work@onurozkan.dev>

statically link libusb

e71e2cf

Signed-off-by: ozkanonur <work@onurozkan.dev>

shamardy previously approved these changes Mar 21, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

onur-ozkan dismissed shamardy’s stale review via 53b2986 March 22, 2023 08:29

onur-ozkan added 2 commits March 22, 2023 11:29

add changelog entry

53b2986

Signed-off-by: ozkanonur <work@onurozkan.dev>

fix test_tendermint_activation_and_balance test

e031b29

Signed-off-by: ozkanonur <work@onurozkan.dev>

ca333 merged commit ba26cb6 into dev Mar 23, 2023
20 checks passed

shamardy deleted the dep-work branch March 23, 2023 23:15

ca333 mentioned this pull request Mar 27, 2023

[release] 1.0.1-beta #1721

Merged

onur-ozkan mentioned this pull request Apr 4, 2023

Enable clippy --all-features on CI #1744

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sec fixes, build-time optimizations, dependency optimizations, CI migration, etc #1699

sec fixes, build-time optimizations, dependency optimizations, CI migration, etc #1699

onur-ozkan commented Mar 7, 2023 •

edited

ca333 left a comment

ca333 Mar 16, 2023

ca333 Mar 16, 2023

ca333 Mar 16, 2023

onur-ozkan Mar 21, 2023

shamardy left a comment

		bincode = { version = "1.3.3", default-features = false, optional = true }
		ed25519-dalek-bip32 = { version = "0.2.0", default-features = false, optional = true }

sec fixes, build-time optimizations, dependency optimizations, CI migration, etc #1699

sec fixes, build-time optimizations, dependency optimizations, CI migration, etc #1699

Conversation

onur-ozkan commented Mar 7, 2023 • edited

ca333 left a comment

Choose a reason for hiding this comment

ca333 Mar 16, 2023

Choose a reason for hiding this comment

ca333 Mar 16, 2023

Choose a reason for hiding this comment

ca333 Mar 16, 2023

Choose a reason for hiding this comment

onur-ozkan Mar 21, 2023

Choose a reason for hiding this comment

shamardy left a comment

Choose a reason for hiding this comment

onur-ozkan commented Mar 7, 2023 •

edited