Minor fixes for upcoming v1.0.4-beta release #1827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
shamardy
changed the title
|
Can we fix the moralis tests in this PR? @laruh |
onur-ozkan
previously approved these changes
May 16, 2023
There was a problem hiding this comment.
The changes looks good, but I would like to see the moralis tests fixed as well before shipping this.
cc @laruh
mm2src/coins/nft.rs
Outdated
| @@ -103,7 +103,7 @@ pub async fn get_nft_metadata(_ctx: MmArc, req: NftMetadataReq) -> MmResult<Nft, | |||
| let token_address = &req.token_address; | |||
| let token_id = &req.token_id; | |||
| let uri = format!( | |||
| "{req_url}{MORALIS_API_ENDPOINT}nft/{token_address}/{token_id}?chain={chain_str}&{FORMAT_DECIMAL_MORALIS}" | |||
| "{req_url}{MORALIS_API_ENDPOINT}nft/{token_address:#02x}/{token_id}?chain={chain_str}&{FORMAT_DECIMAL_MORALIS}" | |||
There was a problem hiding this comment.
not a blocker: Since req_url is a Url type, we can use join method instead of building string here.
|
Thanks for the fixes. rpcs work well. native test_moralis_nft_transfer_history test #[test]
fn test_moralis_nft_transfer_history() {
let response = block_on(send_request_to_uri(NFT_HISTORY_URL_TEST)).unwrap();
let mut transfer_list = response["result"].as_array().unwrap().clone();
assert_eq!(4, transfer_list.len());
let last_tx = transfer_list.remove(0);
let transfer_wrapper: NftTransferHistoryWrapper = serde_json::from_str(&last_tx.to_string()).unwrap();
assert_eq!(TEST_WALLET_ADDR_EVM, transfer_wrapper.from_address);
}next wasm target wasm test_moralis_nft_transfer_history #[wasm_bindgen_test]
async fn test_moralis_nft_transfer_history() {
let response = send_request_to_uri(NFT_HISTORY_URL_TEST).await.unwrap();
let mut transfer_list = response["result"].as_array().unwrap().clone();
assert_eq!(4, transfer_list.len());
let last_tx = transfer_list.remove(0);
let transfer_wrapper: NftTransferHistoryWrapper = serde_json::from_str(&last_tx.to_string()).unwrap();
assert_eq!(TEST_WALLET_ADDR_EVM, transfer_wrapper.from_address);
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1804 (review), #1804 (review)