fix(orderbook): age field is set in proper way #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onur-ozkan
reviewed
May 31, 2023
borngraced
requested changes
May 31, 2023
onur-ozkan
reviewed
May 31, 2023
|
Can you pull |
updated, squashed, rebased |
rozhkovdmitrii
force-pushed
the
1850-legacy-orderbook-age
branch
from
8f58fb8
to
c3478a5
Compare
onur-ozkan
previously approved these changes
Jun 1, 2023
shamardy
requested changes
Jun 2, 2023
onur-ozkan
reviewed
Jun 5, 2023
mm2src/mm2_main/src/lp_ordermatch.rs
Outdated
| ($created_at: expr) => { | ||
| now_sec() | ||
| .checked_sub($created_at) | ||
| .ok_or_else(|| warn!("now - created_at: ({} - {}) caused an u64 underflow.", $base, $sub)) |
There was a problem hiding this comment.
u64 starts with a vowel sound
Suggested change
| .ok_or_else(|| warn!("now - created_at: ({} - {}) caused an u64 underflow.", $base, $sub)) | |
| .ok_or_else(|| warn!("now - created_at: ({} - {}) caused a u64 underflow.", $base, $sub)) |
onur-ozkan
reviewed
Jun 5, 2023
mm2src/mm2_main/src/lp_ordermatch.rs
Outdated
| .ok_or_else(|| warn!("now - created_at: ({} - {}) caused an u64 underflow.", $base, $sub)) | ||
| .unwrap_or_default() | ||
| .try_into() | ||
| .expect("Expected default u64 converted to i64 without a problem") |
There was a problem hiding this comment.
Suggested change
| .expect("Expected default u64 converted to i64 without a problem") | |
| .expect("Expected default u64 to be converted to i64 without a problem") |
rozhkovdmitrii
force-pushed
the
1850-legacy-orderbook-age
branch
from
b8b298f
to
6b44667
Compare
shamardy
approved these changes
Jun 9, 2023
onur-ozkan
pushed a commit
that referenced
this pull request
Jun 13, 2023
When orderbook is requested the age field now returns the right age.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When orderbook is requested the age is often different and the same for each order. This behavior has been solved