Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(adex-cli): secure connection provided #1910

Merged
merged 12 commits into from Aug 2, 2023
Merged

feat(adex-cli): secure connection provided #1910

merged 12 commits into from Aug 2, 2023

Conversation

rozhkovdmitrii
Copy link

@rozhkovdmitrii rozhkovdmitrii commented Jul 11, 2023 •
edited

Dependency updates

Package From To Compare mm2 Cargo.lock
core-foundation NEW 0.9.3 not present
openssl-probe NEW 0.1.5 not present
rustls-native-certs NEW 0.6.3 not present
rustls-pemfile NEW 1.0.3 not present
schannel NEW 0.1.22 not present
security-framework NEW 2.9.1 not present
security-framework-sys NEW 2.9.0 not present

@rozhkovdmitrii rozhkovdmitrii added in progress Changes will be made from the author adex-cli labels Jul 11, 2023
@rozhkovdmitrii rozhkovdmitrii self-assigned this Jul 11, 2023
@onur-ozkan onur-ozkan changed the title feat(adex-cli): sucure connection provided feat(adex-cli): secure connection provided Jul 11, 2023
@rozhkovdmitrii rozhkovdmitrii added under review and removed in progress Changes will be made from the author labels Jul 11, 2023
@rozhkovdmitrii rozhkovdmitrii marked this pull request as ready for review July 11, 2023 18:34
@rozhkovdmitrii rozhkovdmitrii linked an issue Jul 11, 2023 that may be closed by this pull request
implement secure (https) tcp connection in adex-cli #1873
Open
@onur-ozkan onur-ozkan requested review from artemii235 and removed request for onur-ozkan July 11, 2023 19:19
borngraced
borngraced previously approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@borngraced borngraced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work. just one grammar correction and the rest looks good to me

@rozhkovdmitrii rozhkovdmitrii requested review from shamardy and removed request for artemii235 July 17, 2023 18:45
Merge branch 'dev' into 1873-adex-cli-https
b1b67c2 
# Conflicts:
#	mm2src/adex_cli/src/tests/mod.rs
shamardy
shamardy previously approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Only one non-blocker.

mm2src/mm2_net/src/native_http.rs Outdated Show resolved Hide resolved
@shamardy shamardy merged commit 867a01a into dev Aug 2, 2023
23 of 30 checks passed
@shamardy shamardy deleted the 1873-adex-cli-https branch August 2, 2023 23:19
@shamardy shamardy mentioned this pull request Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamardy shamardy shamardy approved these changes

@borngraced borngraced Awaiting requested review from borngraced

Assignees

@rozhkovdmitrii rozhkovdmitrii

Labels
adex-cli under review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement secure (https) tcp connection in adex-cli
3 participants
@rozhkovdmitrii @shamardy @borngraced