Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): use the updated activation scheme #1938

Merged
merged 1 commit into from Aug 24, 2023

Conversation

rozhkovdmitrii
Copy link

@rozhkovdmitrii rozhkovdmitrii commented Aug 15, 2023

Activation scheme was changed and that is why the related data types had to be fit to it

Related changes in kmd_ntx_stats_docker

@onur-ozkan
Copy link
Member

Could you refer the changes made on activation? So we can compare/review this PR with it.

@rozhkovdmitrii
Copy link
Author

Could you refer the changes made on activation? So we can compare/review this PR with it.

@ozkanonur, thank you for pointing it out. Done

Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shamardy shamardy changed the title fix(cli): fit to the changed activation scheme fix(cli): use the updated activation scheme Aug 24, 2023
@shamardy shamardy merged commit 9d5ab11 into dev Aug 24, 2023
27 of 35 checks passed
@shamardy shamardy deleted the fix-fit-to-the-changed-activation-scheme branch August 24, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants