feat(hd_wallet): evm hd wallet and trezor #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamardy
force-pushed
the
evm-hd-wallet
branch
from
412ec5e
to
bd5cfd4
Compare
artemii235
requested changes
Oct 3, 2023
|
Thanks you for the review @artemii235, I will continue working through this list #1979 (comment) in this sprint by adding new commits to this PR, so next review in a few weeks should be for commits after this comment only to make it easier to review :) |
dimxy
reviewed
Oct 12, 2023
…_addresses rpcs for evm
…refactor some swap methods to be async
dimxy
reviewed
Apr 2, 2024
dimxy
reviewed
Apr 3, 2024
laruh
requested changes
Apr 3, 2024
| .collect() | ||
| } | ||
|
|
||
| // Todo: combine both implementations once worker threads are supported in WASM |
There was a problem hiding this comment.
Could you remind me please, as far as I remember we added worker support in wasm, right?
Do we need something else for this todo?
There was a problem hiding this comment.
Workers need to be supported from the GUI side as well by adding a worker file for this and implementing any needed code in the worker file if there is any.
…vationMethod` and implement a default implementation for it * Remove `my_addresses` from `utxo_tx_history_v2_common.rs` and use `all_addresses` in place of it
dimxy
reviewed
Apr 5, 2024
…WithTokensError::Internal` error
|
@onur-ozkan just need you to check this change #1979 (comment) and if it's alright by you. |
19 tasks
5 tasks
…to `ERC20DEV` conf
* Add address_formatter higher-order function to HDWalletCoinOps to display eth addresses correctly * add enable_eth_with_tokens_v2 test helper * fix test_enable_eth_erc20_coins_with_enable_hd * fix test_withdraw_and_send_hd_eth_erc20
* remove `wasm_test_withdraw_eth` and `test_send` since they use `ETH_DEV_NODE` # ignore `swap_usdc_ibc_with_nimda` since it needs periodical funding
…he address was funded
…see if that fixes things
…ts can still be unstable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1838
This is an in progress PR:
HDWalletderivation toEthCoin.HDWalletCoinOps,HDWalletBalanceOps, etc.. forEthCoin.init_platform_coin_with_tokensusing task manager forEthCoin.init_tokenusing task manager.Changes:
chain_idis needed for all evm coins/tokens.chain_idshould be part of platform coin config only actually and retrieved from platform coin, this is for v2 methods, but we should keep it in all coins config for v1 methods.