Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orders list keeps auto-scrolling to the top #125

Closed
jansako opened this issue Apr 30, 2020 · 8 comments
Closed

Orders list keeps auto-scrolling to the top #125

jansako opened this issue Apr 30, 2020 · 8 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request Front-end next iteration to not forget to include it P1 Major issue needs to be fixed

Comments

@jansako
Copy link

jansako commented Apr 30, 2020

Win10.

Issue: The current orders list auto-jumps to the top every few seconds. Possibly the result of the orderbook call.

Expected: When scrolling the orderbook, the window position does not auto-jump :-)

Nice to have: remember the position of the list when toggling between tabs Trade/Orders/History

@Milerius Milerius added bug Something isn't working enhancement New feature or request UI labels Apr 30, 2020
@naezith
Copy link
Contributor

naezith commented Apr 30, 2020

Thanks for reporting. Reason of this happening is, when list updates, entire QML list object is being recreated. We had similar issues at some other places and searched for solutions but there isn't a pure QML solution to this as I remember. Only way was to use a dependency which prevents the list recreation and changes only the items which really changed.

We'll discuss this, adding a dependency just for this is not preferable.

@jansako
Copy link
Author

jansako commented May 1, 2020

Just reducing the frequency of update would be a huge improvement. Right now if you were to have a list of 20 orders, you can never see the last one as it would jump to the top before you can scroll all the way down :-)

Consider these options:

  • only recreate the list when switching tabs OR once a minute, maybe 2 minutes
  • add a 'refresh' button that would rebuild it on demand
  • split the list into smaller (screen sized?- LOL) segments, or even each order on a separate segment. Then you can refresh them individually per above. You would not need to separate the segments visually, so the user would not know at all.

I can imagine you guys are probably working on some sort of grid/sort system for the order lists, so I am just throwing out ideas :-).

@lilszi
Copy link

lilszi commented Jul 2, 2020

still an issue

@tonymorony tonymorony added the next iteration to not forget to include it label Jul 2, 2020
@tonymorony tonymorony added the P1 Major issue needs to be fixed label Jul 8, 2020
@tonymorony
Copy link
Contributor

tonymorony commented Jul 8, 2020

thats looks actual for all list (dashboard, orderbooks) on tick so looks like the next candidate for fixing after #337 :)

@tonymorony
Copy link
Contributor

fixed in #367

@ca333 ca333 mentioned this issue Jul 24, 2020
@lilszi
Copy link

lilszi commented Aug 1, 2020

still happening in 0.2.0 in trade window when selecting coin from list

@tonymorony
Copy link
Contributor

tonymorony commented Aug 1, 2020

@lilszi hmm I was not able to reproduce that with coins seletction in both base and rel lists - could you please share reproducion steps?
however, there is similar problem for orderbook's order selection list in 0.2.0 - but orderbook is under rework so it will be resolved

@tonymorony
Copy link
Contributor

can't reproduce it anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request Front-end next iteration to not forget to include it P1 Major issue needs to be fixed
Projects
None yet
Development

No branches or pull requests

5 participants