Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: wrong chart in DEX tab after switching base from KMD to USDx #1315

Closed
cipig opened this issue Sep 18, 2021 · 7 comments · Fixed by #1701
Closed

[BUG]: wrong chart in DEX tab after switching base from KMD to USDx #1315

cipig opened this issue Sep 18, 2021 · 7 comments · Fixed by #1701
Assignees
Labels
bug Something isn't working P2 Time permissive

Comments

@cipig
Copy link
Member

cipig commented Sep 18, 2021

Switching from SMTF/KMD to SMTF/USDC in DEX tab by clicking on "Best Orders" (buy SMTF) entry USDC shows chart of KMD/USD:
image
The bug can be reproduced with any stablecoin, switching base from KMD to BUSD has the same.
If switching base from KMD to USDx from coin selection dropdown, the bug is not there, only through "Best Orders".

@cipig cipig added the bug Something isn't working label Sep 18, 2021
@tonymorony tonymorony added P2 Time permissive 0.5.2 labels Sep 19, 2021
@tonymorony tonymorony removed this from To do in AtomicDEX Desktop 0.5.4 Dec 2, 2021
@cipig cipig mentioned this issue Dec 14, 2021
@tonymorony tonymorony added 0.5.5 and removed 0.5.4 labels Dec 21, 2021
@tonymorony tonymorony added this to To do in AtomicDEX 0.5.5 Dec 21, 2021
@tonymorony tonymorony added 0.5.6 and removed 0.5.5 labels Mar 21, 2022
@tonymorony tonymorony removed this from To do in AtomicDEX 0.5.5 Mar 21, 2022
@tonymorony tonymorony added this to To do in AtomicDEX 0.5.6 Mar 21, 2022
@smk762
Copy link
Collaborator

smk762 commented Mar 21, 2022

@cipig I've been unable to reproduce this one, can you please try again and add a short video of the steps?

@cipig
Copy link
Member Author

cipig commented Mar 21, 2022

can't record videos, but follow this steps:

  1. go to SMTF/KMD orderbook (no chart)
    image
  2. click on a sell order, so that best_orders show up
    image
  3. click on the USDCentry, the orderbook will change to SMTF/USDC
  4. result: it shows the charts of KMD/USD
    image

@smk762
Copy link
Collaborator

smk762 commented Mar 29, 2022

Not sure why, but my CLI bestorders response has items not visible in the app. This is using same mm2 instance as in app with app rpcpass.
image
bestorders.txt

@smk762
Copy link
Collaborator

smk762 commented Mar 30, 2022

@cipig appears to be resolved in https://github.com/KomodoPlatform/atomicDEX-Desktop/actions/runs/2057679427 can you please confirm?
Currently I see no chart for SMTF-v2 / KMD, nor SMTF-v2 / USDC when selecting from bestorders. Same for BUSD & USDT etc.

@cipig
Copy link
Member Author

cipig commented Mar 31, 2022

weird, i still have the problem

  • open SMTF/KMD orderbook
  • click on a SMTF ask (as if you would want to buy SMTF and pay with KMD)
  • click on the USDC entry in best orders (orderbook switches to SMTF/USDC)
  • ADEX shows chart of KMD/USD
    image

@smk762
Copy link
Collaborator

smk762 commented Mar 31, 2022

replicated here also, previously was doing opposite of click on a SMTF ask (as if you would want to buy SMTF and pay with KMD) i.e. clicking on bid (sell SMTF).

Also replicated with same sequence using BTC instead of SMTF. Might need to add some logs to track this down.

@cipig
Copy link
Member Author

cipig commented Apr 1, 2022

bug is there if you switch from xxx/KMD orderbook to xxx/USD orderbook
it then shows KMD/USD chart, instead of xxx/USD
so there is a pattern
somewhere in code (switching orderbook), it selects the wrong side when asking for charts (base is rel and rel is base)

@smk762 smk762 mentioned this issue Apr 1, 2022
@smk762 smk762 moved this from To do to Testing in AtomicDEX 0.5.6 Apr 1, 2022
@smk762 smk762 self-assigned this Apr 1, 2022
@smk762 smk762 mentioned this issue Apr 1, 2022
@smk762 smk762 moved this from Testing to Done in AtomicDEX 0.5.6 Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2 Time permissive
Projects
No open projects
4 participants