Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new dex view design #1561

Merged
merged 51 commits into from Apr 1, 2022
Merged

Implement new dex view design #1561

merged 51 commits into from Apr 1, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jan 17, 2022

Closes #1268
Closes #1342
Closes #1488

@ghost ghost added the 0.5.5 label Jan 17, 2022
@ghost ghost requested review from tonymorony and smk762 January 17, 2022 06:08
syl added 16 commits February 4, 2022 11:55
Change "Trading Information" text style
Change tab indicator color in trading informations section
Change padding in trading informations section
Change orders/history style
Change order book style
Change best order list style
Change place order form subtitle
Change order book view title style
Edit separator maximum width between header and list
Remove trailing whitespaces between date and hour
@ghost ghost marked this pull request as ready for review February 7, 2022 11:31
@smk762
Copy link
Collaborator

smk762 commented Feb 9, 2022

When sidebar expanded, orderform overflows. Seems extra whitespace next to sidebar.
image
image

history data clipped
image

@tonymorony
Copy link
Contributor

There is no chart at the moment

Figma:

image

history data clipped ref such cases I think we should ask @polevin to draw pro view for minimal app size, that should help. right now it drawn for maximised window

@SylEze what is the min screen size you need design for?

@smk762
Copy link
Collaborator

smk762 commented Feb 9, 2022

It is also clipped at full screen size @ 3840*1080
image

@tonymorony
Copy link
Contributor

@SylEze what is the min screen size you need design for?

@tonymorony
Copy link
Contributor

looks good so far on my side, great job!

@Canialon could you please carefully test DEX -> Pro view?

the only pb I noticed so far is a small glitch on modal:

Screenshot 2022-03-28 at 23 56 46

@smk762
Copy link
Collaborator

smk762 commented Mar 29, 2022

Closes #1463

  • Need to test this on a different monitor

Closes #1268

  • No tooltip seen for insufficient gas error
  • There is now whitespace where tooltip used to be - we should re-align columns so price is closer to left edge of line.
    image

Closes #1342 ✔️

  • Overflow no longer visible, and ellipses visible in both light/dark
  • We could improve this with more linebreaks or "mouseover ticker shows fullname" & "mouseover balance shows fiat value", but will leave that for a future PR
    image
    image

Closes #1473

  • I still see some chart dancing when sidebar expands if the orderbook / form is hidden. It's ok when everything shown tho.
chart-expand-retract.mp4

Closes #1488 ✔️

  • Aligned right as requested

@smk762
Copy link
Collaborator

smk762 commented Mar 29, 2022

P.S. lets try to solve in this rework as many small issues related to this view as possible:

#1488

  • Comment above, fixed in current CI build for this branch

#1473

  • Comment above

#1462

  • Awaiting figma design

#1342

  • Comment above, fixed in current CI build for this branch

#1315

  • Still unable to replicate locally (no stablecoins in my bestorders list, even when creating one externally. Potential bug, should relegate to new issue)

#1326

#1268

  • Comment above

#858

@ghost
Copy link
Author

ghost commented Mar 29, 2022

P.S. lets try to solve in this rework as many small issues related to this view as possible:
#1488

* Comment above, fixed in current CI build for this branch

#1473

* Comment above

#1462

* Awaiting figma design

#1342

* Comment above, fixed in current CI build for this branch

#1315

* Still unable to replicate locally (no stablecoins in my bestorders list, even when creating one externally. Potential bug, should relegate to new issue)

#1326

* being worked on in [Show full coin name (including protocol) in a best orders row #1688](https://github.com/KomodoPlatform/atomicDEX-Desktop/pull/1688)

#1268

* Comment above

#858

* Closed by [redraw bars when data changes #1666](https://github.com/KomodoPlatform/atomicDEX-Desktop/pull/1666)

I will not fix every issue mentionned in this PR, only the issues I put in the description

It has already sufficient changes: those ones will be fixed in another pull requests

@smk762
Copy link
Collaborator

smk762 commented Mar 29, 2022

@SylEze @tonymorony suggest we merge this in current state and then address the following issues separately (or move to new issues):

Copy link
Collaborator

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, outstanding issues to be dealt with separately. @SylEze please remove incomplete issue numbers # from your comment before merging so they don't close prematurely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants