Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Bestorders doesnt indicate where ERC / BEP variant #1326

Closed
smk762 opened this issue Sep 22, 2021 · 3 comments · Fixed by #1688
Closed

[BUG]: Bestorders doesnt indicate where ERC / BEP variant #1326

smk762 opened this issue Sep 22, 2021 · 3 comments · Fixed by #1688
Labels
bug Something isn't working

Comments

@smk762
Copy link
Collaborator

smk762 commented Sep 22, 2021

Describe the bug
In the bestorders table, most coins are only listed once.
In the case of coins like BTC which also have a BTC-BEP variant, both are listed as "BTC", and user can't tell if it is BEP20 or not until clicking on the line and checking the form.

To Reproduce
Steps to reproduce the behavior:

  1. Go to DEX page
  2. Look at bestorders
  3. See 2 BTC entries
  4. Click on entries to see if BEP20 or not.

Expected behavior
BTC-BEP20 is listed as such in the bestorders table (and same for others like ETH-BEP20 etc)

Screenshots
image

@smk762 smk762 added the bug Something isn't working label Sep 22, 2021
@ghost ghost assigned ghost and unassigned Milerius Sep 22, 2021
@smk762
Copy link
Collaborator Author

smk762 commented Feb 15, 2022

With segwit integration, this will also need to be handled.
Coins file has BTC, BTC-segwit, BTC-BEP20 etc.

@tonymorony
Copy link
Contributor

BTC, BTC-segwit - for segwit option it's fine to show only ticker since it's possible to match segwit order with legacy balance and vice versa and also BTC and BTC-segwit got the same orderbook

For tokens (BEP20, ERC20, ...) there is a separate orderbook and you can't match BTC-BEP20 order with BTC balance so indication is needed

@smk762
Copy link
Collaborator Author

smk762 commented Feb 16, 2022

yep - group BTC/BTC-segwit under "BTC", display others with protocol.

@tonymorony tonymorony unassigned ghost and tonymorony Mar 2, 2022
@tonymorony tonymorony added this to To do in AtomicDEX 0.5.6 Mar 21, 2022
@ghost ghost moved this from To do to Testing in AtomicDEX 0.5.6 Apr 4, 2022
@ghost ghost closed this as completed in #1688 Apr 4, 2022
@tonymorony tonymorony moved this from Testing to Done in AtomicDEX 0.5.6 Apr 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants