Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST]: add nomics charts #1420

Closed
cipig opened this issue Nov 11, 2021 · 2 comments · Fixed by #1789
Closed

[FEATURE REQUEST]: add nomics charts #1420

cipig opened this issue Nov 11, 2021 · 2 comments · Fixed by #1789
Assignees
Labels
enhancement New feature or request

Comments

@cipig
Copy link
Member

cipig commented Nov 11, 2021

Adding charts from nomics has this advantages:

  • we can have charts for all base coins, eg BTCZ/KMD
  • we don't have to configure tradingview pairs for each new coin and each new pair

example code

<div class="nomics-ticker-widget" data-name="BitcoinZ" data-base="BTCZ" data-quote="KMD"></div><script src="https://widget.nomics.com/embed.js"></script>

from https://nomics.com/assets/btcz-bitcoinz/widget

data-base and data-quote are the nomics_id from coins config: https://github.com/KomodoPlatform/atomicDEX-Desktop/blob/dev/assets/config/0.5.2-coins.json#L1107

We can either use nomics when no tradingview pair is configured or replace tradingview completely.

@Milerius
Copy link
Contributor

Milerius commented Nov 12, 2021

Adding charts from nomics has this advantages:

  • we can have charts for all base coins, eg BTCZ/KMD
  • we don't have to configure tradingview pairs for each new coin and each new pair

example code

<div class="nomics-ticker-widget" data-name="BitcoinZ" data-base="BTCZ" data-quote="KMD"></div><script src="https://widget.nomics.com/embed.js"></script>

from https://nomics.com/assets/btcz-bitcoinz/widget

data-base and data-quote are the nomics_id from coins config: https://github.com/KomodoPlatform/atomicDEX-Desktop/blob/dev/assets/config/0.5.2-coins.json#L1107

We can either use nomics when no tradingview pair is configured or replace tradingview completely.

Thanks for opening the issue, unfortunately this widget have a better suits for the wallet view rather than the pro view, however I see that nomics have a tradingview chart also for each pair, maybe we can gently ask them the URL to use it in our project

https://nomics.com/exchanges/atomicdex/markets/DASH_LTC

@tonymorony tonymorony assigned smk762 and unassigned Milerius, tonymorony and smk762 Feb 22, 2022
@tonymorony tonymorony added the next iteration to not forget to include it label Feb 22, 2022
@smk762
Copy link
Collaborator

smk762 commented Feb 24, 2022

Nomics charts (via widget) don't offer a darkmode yet.

@tonymorony tonymorony added 0.5.6 enhancement New feature or request and removed next iteration to not forget to include it labels Mar 21, 2022
@tonymorony tonymorony added this to To do in AtomicDEX 0.5.6 Mar 21, 2022
@smk762 smk762 moved this from To do to In progress in AtomicDEX 0.5.6 Jun 12, 2022
@smk762 smk762 self-assigned this Jun 12, 2022
@smk762 smk762 moved this from In progress to Testing in AtomicDEX 0.5.6 Jun 12, 2022
@smk762 smk762 moved this from Testing to Done in AtomicDEX 0.5.6 Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants