Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(price_service): transition to komodo price service #1266

Merged
merged 40 commits into from
Sep 15, 2021

Conversation

Milerius
Copy link
Contributor

@Milerius Milerius commented Sep 10, 2021

This pr introduce the komodo price service and replace the coingecko one

Everything related to price in general need to be tested

@Milerius Milerius marked this pull request as ready for review September 10, 2021 09:41
@Milerius Milerius requested review from smk762 and a user September 10, 2021 09:41
@smk762
Copy link
Collaborator

smk762 commented Sep 14, 2021

Slight overlap on price source icon (when set to other currencies like AUD. HKD, IDR etc)
image
image

Instead of "Price provider is: {coin}", can we set to "Price source: {coin}

Is Band oracle still being used for some things?
image
image
image

@Milerius
Copy link
Contributor Author

Slight overlap on price source icon (when set to other currencies like AUD. HKD, IDR etc)
image
image

Instead of "Price provider is: {coin}", can we set to "Price source: {coin}

Is Band oracle still being used for some things?
image
image
image

Good catch. The text need to be changed, likely for the band source. It's only used for BAND now.

@tonymorony tonymorony self-requested a review September 14, 2021 07:30
@tonymorony
Copy link
Contributor

tonymorony commented Sep 14, 2021

Supernet assets shouldn't be availiable on simple trading view:

Screen.Recording.2021-09-14.at.14.30.27.mov

Copy link
Contributor

@tonymorony tonymorony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^

@Milerius
Copy link
Contributor Author

Milerius commented Sep 14, 2021

Supernet assets should be available on simple trading view:

Screen.Recording.2021-09-14.at.14.30.27.mov

You mean shouldn't be?

yes :) (additional condition for wallet_only: true coins is needed I wonder)

@tonymorony
Copy link
Contributor

@SylEze @Milerius there is a conflict with dev atm

Conflicting files
atomic_defi_design/qml/Portfolio/AssetsList.qml

so CI not triggered

@tonymorony tonymorony merged commit 7b7c48f into dev Sep 15, 2021
@Milerius Milerius deleted the komodo_price_service branch September 15, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants