Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page switching crash #1274

Merged
merged 10 commits into from
Sep 14, 2021
Merged

Fix page switching crash #1274

merged 10 commits into from
Sep 14, 2021

Conversation

ghost
Copy link

@ghost ghost commented Sep 13, 2021

Closes #1273

@ghost ghost requested a review from smk762 September 13, 2021 12:30
@smk762
Copy link
Collaborator

smk762 commented Sep 13, 2021

So far so good on windows - will continue to test tomorrow and see if I can break it

@Milerius
Copy link
Contributor

Milerius commented Sep 14, 2021

Capture d’écran 2021-09-14 à 06 50 27

image

would be nice to fix the global web engine behavior too then

eg: go on TKL in the wallet page, go on the trading page, choose KMD/BTC, go back to the wallet page

Copy link
Collaborator

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created global chart issue at #1276

Tab switching appears to be robust here 👍

@Milerius Milerius merged commit c541631 into dev Sep 14, 2021
@Milerius Milerius deleted the fix_page_switching_crash branch September 14, 2021 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Quick page switching might cause the app to crash
2 participants